16408 Commits

Author SHA1 Message Date
Robert Schäfer
3253297c23
Merge pull request #545 from Human-Connection/dependabot/npm_and_yarn/backend/neo4j-driver-1.7.4
Bump neo4j-driver from 1.7.3 to 1.7.4 in /backend
2019-05-06 23:05:26 +02:00
Robert Schäfer
ea22a4676e
Merge pull request #549 from Human-Connection/dependabot/npm_and_yarn/webapp/babel-jest-24.8.0
Bump babel-jest from 24.7.1 to 24.8.0 in /webapp
2019-05-06 23:04:52 +02:00
Robert Schäfer
f27dca504b Refactor mixin with computed property
@ulfgebhardt I refactored the mixin because it's not enough code to
justify the additional complexity. If it's just two lines of code, I
find it the best solution to use a computed property.

You can use components and computed properties excessively, they tend to
be easier to maintain in the long run.
2019-05-06 22:59:25 +02:00
Robert Schäfer
ad111f5701 Double-check changed expectations, fix tests
See:
https://github.com/Human-Connection/Human-Connection/pull/478/files#r281267486

> We found the reason for it: If you have an exclamation mark in the schema e.g.
> email! and the response would e.g. expect the email for each User object, and
> the server does not have an email for the client, then the entire User object
> gets nullified.
2019-05-06 19:26:53 +02:00
Wolfgang Huß
41711c316a Get delete SocialMedia to work, refactored Frontend Jest tests, written Cypress tests
Optimised tests and Vue for add Social Media a bit.
Added localisation.

Finished this commit together with @mattwr18 !!!
Thank you so much dude! You did great stuff …
2019-05-06 17:31:02 +02:00
e26b2eabcc
transalte status messages in validation 2019-05-06 15:06:23 +02:00
f3f0b40537
bind to sytleguide on password strength component, transalte security settings labels, bind to user input validation function which is not working currently 2019-05-06 14:46:15 +02:00
9fcddfbd97
Merge branch 'master' into 2019/kw15/change_password_strength 2019-05-06 13:59:03 +02:00
ee2e9409b1
output to linux dev null again 2019-05-06 13:30:10 +02:00
9004e923af
removed unnecessary comment block 2019-05-06 13:02:09 +02:00
a71b421933
removed console log 2019-05-06 12:39:53 +02:00
dependabot[bot]
c046524b8f
Bump babel-jest from 24.7.1 to 24.8.0 in /webapp
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest) from 24.7.1 to 24.8.0.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v24.8.0/packages/babel-jest)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-06 04:59:48 +00:00
dependabot[bot]
0beb2d1763
Bump neo4j-driver from 1.7.3 to 1.7.4 in /backend
Bumps [neo4j-driver](https://github.com/neo4j/neo4j-javascript-driver) from 1.7.3 to 1.7.4.
- [Release notes](https://github.com/neo4j/neo4j-javascript-driver/releases)
- [Commits](https://github.com/neo4j/neo4j-javascript-driver/compare/1.7.3...1.7.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-06 04:46:30 +00:00
Matt Rider
4c09268f49 Update tests after backend validations
- Now a comment cannot be created without a post to associate it with
2019-05-05 13:57:12 -03:00
Matt Rider
ad46c2d059 Remove cypress test
- it is not part of the scope of this ticket, and therefore should be extracted and dealt with separately
2019-05-05 12:26:02 -03:00
Matt Rider
1fff9bbc46 Add cypress test to expose comment creation bug
- at the moment, one can create the same comment by clicking rapidly on the "Comment" button
- an idea for a fix https://stackoverflow.com/questions/53101521/prevent-repeated-queries-in-apollo-server-2
2019-05-04 18:46:34 -03:00
Matt Rider
4d631c452d Add more unit tests, add back postId deletion 2019-05-04 17:42:42 -03:00
Wolfgang Huß
2af9b853a1 Add first try of Webapp Component Test
Add `ìd` to the SocialMedia data
2019-05-04 10:13:40 +02:00
Matt Rider
70fb34345d Improve test by mounting CommentList with data 2019-05-03 15:53:16 -03:00
Matt Rider
da218f8a58 Add component test for extracted CommentList.vue 2019-05-03 15:48:20 -03:00
Matt Rider
d1c8682710 Update method name to be more descriptive/accurate 2019-05-03 15:47:54 -03:00
aonomike
f4b054d4c5 Fix linting error 2019-05-03 20:46:58 +03:00
Matt Rider
31c8b6e35d Use single cypher query in CreateComments
- to create relation between post, comment, author
- fix test to create a post so said cypher query doesn't silently fail
2019-05-03 13:41:20 -03:00
Matt Rider
ebc290c6af Delete CommentForm.test.js, remove console.log
- this test is not part of this PR and I'll create another issue and put in a different PR for it
2019-05-03 13:39:43 -03:00
Matt Rider
957d894322 Start writing component test
- restructured directories
2019-05-03 11:18:14 -03:00
aonomike
f8ff40148c Add implementation to prefix relative image urls with '/api' 2019-05-03 16:21:33 +03:00
dependabot[bot]
54fe0a58e2
Bump graphql-shield from 5.3.4 to 5.3.5 in /backend
Bumps [graphql-shield](https://github.com/maticzav/graphql-shield) from 5.3.4 to 5.3.5.
- [Release notes](https://github.com/maticzav/graphql-shield/releases)
- [Commits](https://github.com/maticzav/graphql-shield/compare/v5.3.4...v5.3.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-03 04:51:08 +00:00
Matt Rider
40f5b6acd5 Extract CommentsList component
- this allows to Query for comments by Post
2019-05-02 21:03:31 -03:00
Matt Rider
346158da7f Update to use autogenerated Comment Query
- using the custom CommentByPost Query was not returning the author of the Post, therefore the users avatar was not showing up
- there are some weird bugs with the comments, if you dblclick on the button, two comments with the same content are created
- sometimes the comments appear as the bottom of the list, sometimes they appear three comments from the bottom(?)
2019-05-02 19:59:35 -03:00
Matt Rider
154082a251 Add authorship to commments at creation
- Co-authored-by: Mike Aono <aonomike@gmail.com>
2019-05-02 15:54:44 -03:00
Robert Schäfer
b742efd02e
Merge branch 'master' into delete-posts 2019-05-02 19:29:24 +02:00
Wolfgang Huß
3294cffa88 Renamed handleDeleteSocialMedia 2019-05-02 18:09:46 +02:00
ad05dcf735
frontend tests, backend tests 2019-05-02 17:47:34 +02:00
Wolfgang Huß
b03cbb212a First Vue design of delete SocialMedia, custom mutation DeleteSocialMedia
Backend Jest tests for DeleteSocialMedia
New backend Jest tests for CreateSocialMedia
2019-05-02 17:41:54 +02:00
0be2891858
make email a required field for user, tests for front- & backend 2019-05-02 16:17:16 +02:00
Wolfgang Huß
a4f5fdc324 Make SocialMedia Links to target="_blank" 2019-05-02 07:22:32 +02:00
dependabot[bot]
57dfd6fb66
Bump nodemon from 1.18.11 to 1.19.0 in /backend
Bumps [nodemon](https://github.com/remy/nodemon) from 1.18.11 to 1.19.0.
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](https://github.com/remy/nodemon/compare/v1.18.11...v1.19.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-02 04:50:59 +00:00
dependabot[bot]
4f0ded1ff0
Bump nodemon from 1.18.11 to 1.19.0 in /webapp
Bumps [nodemon](https://github.com/remy/nodemon) from 1.18.11 to 1.19.0.
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](https://github.com/remy/nodemon/compare/v1.18.11...v1.19.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-02 04:50:47 +00:00
Robert Schäfer
c3cfe90aa2
Merge pull request #526 from Human-Connection/unexpose_8080
Unexpose irrelevant port 8080
2019-05-02 00:03:39 +02:00
Robert Schäfer
8f40b25cfd
Merge pull request #507 from Human-Connection/dependabot/npm_and_yarn/backend/sanitize-html-1.20.1
Bump sanitize-html from 1.20.0 to 1.20.1 in /backend
2019-05-02 00:03:03 +02:00
Robert Schäfer
5921e0b9f4
Merge pull request #527 from Human-Connection/dependabot/npm_and_yarn/webapp/tiptap-extensions-1.17.0
Bump tiptap-extensions from 1.16.2 to 1.17.0 in /webapp
2019-05-02 00:02:21 +02:00
dependabot[bot]
ce6523b3d9
Bump tiptap-extensions from 1.16.2 to 1.17.0 in /webapp
Bumps [tiptap-extensions](https://github.com/scrumpy/tiptap) from 1.16.2 to 1.17.0.
- [Release notes](https://github.com/scrumpy/tiptap/releases)
- [Commits](https://github.com/scrumpy/tiptap/compare/tiptap-extensions@1.16.2...tiptap-extensions@1.17.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-01 21:02:50 +00:00
Robert Schäfer
5ddda1da0f
Merge pull request #513 from Human-Connection/dependabot/npm_and_yarn/webapp/@babel/preset-env-7.4.4
Bump @babel/preset-env from 7.4.3 to 7.4.4 in /webapp
2019-05-01 22:59:08 +02:00
Robert Schäfer
5572808bdf
Merge pull request #528 from Human-Connection/dependabot/npm_and_yarn/webapp/tiptap-1.17.0
Bump tiptap from 1.16.2 to 1.17.0 in /webapp
2019-05-01 22:58:23 +02:00
Robert Schäfer
497f77ae10 Breakthrough! Use split+indices for performance
@appinteractive thanks for pointing out `split`. You just saved me some
days of work to refactor the import statements to use CSV instead of
JSON files.

@Tirokk when I enter `:schema` in Neo4J web UI, I see the following:
```
:schema
Indexes
   ON :Badge(id) ONLINE
   ON :Category(id) ONLINE
   ON :Comment(id) ONLINE
   ON :Post(id) ONLINE
   ON :Tag(id) ONLINE
   ON :User(id) ONLINE

No constraints
```

So I temporarily removed the unique constraints on `slug` and added
plain indices on `id` for all relevant node types. We cannot omit the
`:Label` unfortunately, neo4j does not allow this. So I had to add all
indices for all known node labels instead.

With indices the import finishes in:
```
Time elapsed: 351 seconds
```
🎉

@appinteractive when I keep the unique indices on slug, I get an error
during import that a node with label `:User` and slug `tobias` already
exists. Ie. we have unqiue constraint violations in our production data.

@mattwr18 @ulfgebhardt @ogerly I started the application on my machine
on the production data and it turns out that the index page
http://localhost:3000/ takes way to long. Visiting my profile page at
http://localhost:3000/profile/5b1693daf850c11207fa6109/robert-schafer
is fine, though. Even pagination works. When I visit a post page with
not too many comments, the application is fast enough, too:
http://localhost:3000/post/5bbf49ebc428ea001c7ca89c/neues-video-format-human-connection-tech-news
2019-05-01 12:25:28 +02:00
dependabot[bot]
8a3ac4ede2
Bump tiptap from 1.16.2 to 1.17.0 in /webapp
Bumps [tiptap](https://github.com/scrumpy/tiptap) from 1.16.2 to 1.17.0.
- [Release notes](https://github.com/scrumpy/tiptap/releases)
- [Commits](https://github.com/scrumpy/tiptap/compare/tiptap@1.16.2...tiptap@1.17.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-01 04:56:44 +00:00
dependabot[bot]
e70bdc4754
Bump sanitize-html from 1.20.0 to 1.20.1 in /backend
Bumps [sanitize-html](https://github.com/punkave/sanitize-html) from 1.20.0 to 1.20.1.
- [Release notes](https://github.com/punkave/sanitize-html/releases)
- [Changelog](https://github.com/punkave/sanitize-html/blob/master/CHANGELOG.md)
- [Commits](https://github.com/punkave/sanitize-html/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-30 21:03:09 +00:00
Robert Schäfer
0fa83188f5
Merge pull request #505 from Human-Connection/dependabot/npm_and_yarn/webapp/nuxt-2.6.3
Bump nuxt from 2.6.2 to 2.6.3 in /webapp
2019-04-30 23:02:17 +02:00
Robert Schäfer
33710e9bc9
Merge branch 'master' into dependabot/npm_and_yarn/webapp/@babel/preset-env-7.4.4 2019-04-30 23:01:16 +02:00
Robert Schäfer
24cb43eb49
Merge pull request #514 from Human-Connection/dependabot/npm_and_yarn/webapp/@vue/cli-shared-utils-3.7.0
Bump @vue/cli-shared-utils from 3.6.0 to 3.7.0 in /webapp
2019-04-30 23:00:13 +02:00