|
|
2cb8d793fb
|
removed failing test
|
2019-05-09 14:37:42 +02:00 |
|
Robert Schäfer
|
287a55db9f
|
Remove test case entirely
@ulfgebhardt when I write "Remove test case" I mean indeed removing all
the lines of code of that test case, not only disabling it. Commenting
out code *and pushing it to version control* is a strong anti-pattern. Why?
First, code comments get out of date quickly. "Never trust code comments".
Second: In our example here, it creates anxiety because other contributors might
believe there was a reason why the commented code exists.
Read:
* https://blog.codinghorror.com/coding-without-comments/
* https://www.nayuki.io/page/dont-share-commented-out-code
* https://softwareengineering.stackexchange.com/questions/1/comments-are-a-code-smell
|
2019-05-07 14:10:12 +02:00 |
|
|
|
3d2ce3960c
|
added url of conversation
|
2019-05-07 14:01:43 +02:00 |
|
|
|
140ba848c7
|
removed testcase, added todo
|
2019-05-07 14:00:02 +02:00 |
|
|
|
9004e923af
|
removed unnecessary comment block
|
2019-05-06 13:02:09 +02:00 |
|
|
|
ad05dcf735
|
frontend tests, backend tests
|
2019-05-02 17:47:34 +02:00 |
|
|
|
0be2891858
|
make email a required field for user, tests for front- & backend
|
2019-05-02 16:17:16 +02:00 |
|
|
|
10ef0ab1c4
|
started backend test, fixed uniqueSlug
|
2019-04-30 19:05:03 +02:00 |
|