Alina Beck
2090e3939b
add $route mock to Comment and CommentList spec
2019-10-15 16:07:09 +03:00
roschaefer
08e73747bd
refactor: set global defaults of vue-scrollto
2019-10-01 17:51:16 +02:00
roschaefer
db1bcdd3d2
refactor: register vue-scrollto in nuxt.config.js
...
This will allow us to use this.$scrollTo in components. I'm now also
using this in the mixin. With so many `this`s it gets horribly
difficult to properly test the mixin in isolation. So I decided to test
the mixin on the component directly.
2019-10-01 17:25:28 +02:00
roschaefer
9da40c4895
fix: avoid many scrollTo calls for n components
...
Thank you @vbelolapotkov for pointing out the flaws here:
https://github.com/Human-Connection/Human-Connection/pull/1756#discussion_r329361572
So here is my attempt to fix it:
* Install `vue-scrollto` which relies on `requestAnimationFrame`
- apparently this is better on Safari and IE? 🤔
- Mocking out entire modules is easier in jest:
https://jestjs.io/docs/en/bypassing-module-mocks
* Require `checkAnchor` to be implemented on the component
2019-10-01 11:55:18 +02:00
Vasily Belolapotkov
2c705a8680
sync with master to resolve merge conflicts
2019-09-29 20:33:39 +03:00
roschaefer
57598df228
refactor: re-use @vbelolapotkov's solution
...
If we make this a mixin, we can re-use the same solution for e.g. the
comment. If sb. notifies you, the browser automatically scrolls to the
comment in which you have been mentioned.
2019-09-29 14:28:38 +02:00
Vasily Belolapotkov
e1751347fc
fix failing client tests
2019-09-25 10:32:35 +03:00
mattwr18
ee99673cec
Add Comment story, add spacing above user info
2019-09-25 08:26:24 +02:00
Vasily Belolapotkov
50feeed8bf
fix the bug with scrolling post comments into view
2019-09-24 12:47:42 +03:00
Alina Beck
a85fab04b6
remove failing test because specs have changed
2019-09-23 22:38:13 +01:00
Alina Beck
3026b923e0
use translated title for comment list
2019-09-23 21:08:20 +01:00
Alina Beck
7104896150
remove sleep icon from comment list
2019-09-23 20:46:41 +01:00
mattwr18
c8a2b03e98
Add removeHtml function in comments tests
2019-09-23 10:04:15 +02:00
mattwr18
0430ab0f74
Fix styling issue in comments list
...
- add back class comments which adds spaces between comments
2019-09-19 15:57:57 +02:00
mattwr18
b1003d8685
Disable tests because of difficulty testing tiptap
2019-09-18 08:56:41 +02:00
Wolfgang Huß
2c732bfbfb
Refactor create and update comment to emit events
2019-09-09 15:53:50 +02:00
roschaefer
1bd57dfeb8
Fix console.errors in test
2019-09-06 16:42:16 +02:00
mattwr18
c2c165c362
Fix lint
2019-09-04 18:45:52 +02:00
mattwr18
e5198babf0
Update the tests with comment.content
2019-09-04 18:01:47 +02:00
roschaefer
491a626031
Replace deleteComment with a more KISS solution
2019-09-03 21:28:29 +02:00
Matt Rider
2af4151918
Update to use <client-only> instead of <no-ssr>
2019-08-26 17:09:24 +02:00
Matt Rider
dbaa8e687f
Fix vue warnings, fix tests, refactor
...
- was throwing an error when trying to update commentsCount because of new implementation by @roschaefer which uses countResolver, but there was no related for commentsCount, it was r... also commentsCount is no longer needed anywhere in the code base, it is commentedCount now
2019-08-16 13:28:55 +02:00
