Wolfgang Huß
63f36f02b4
Clarified variable naming
2020-02-06 09:52:18 +01:00
Wolfgang Huß
ff620171b2
Implement suggestions of Robert
2020-02-06 09:35:15 +01:00
Wolfgang Huß
0161b7f16c
Implement suggestions of Matt
2020-02-05 12:50:16 +01:00
Wolfgang Huß
bef747b9a1
Implement suggestions of Matt
...
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2020-02-05 11:05:37 +01:00
Wolfgang Huß
346a1b0d3e
Merge branch '1709-send-feedbacks-in-report-processes' of github.com:Human-Connection/Human-Connection into 1709-send-feedbacks-in-report-processes
2020-02-03 10:11:10 +01:00
roschaefer
d6f5740ac1
Merge remote-tracking branch 'origin/master' into 1709-send-feedbacks-in-report-processes
2020-02-01 15:12:13 +01:00
mattwr18
c8c71a52c6
Follow @Tirokk PR review suggestions
...
- Favor lowercase for words in a sentence after the first
- Use exclamation marks for successful actions that use a toastr
- place events at the end of the list on components
- place class above events
- it would be nice to come to a consensus based on best practices, like
I had a doubt and places the class definition below the props, is that
what others do?
2020-01-31 13:09:37 +01:00
mattwr18
701411e270
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1680-Direct_answer_on_Comment
2020-01-31 13:08:31 +01:00
mattwr18
60cd593826
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1724-block-users
2020-01-30 10:47:50 +01:00
mattwr18
bcc1ab167e
Improve styling per @alina-beck review
2020-01-30 10:46:43 +01:00
Robert Schäfer
65811e2d8b
Merge pull request #2898 from Human-Connection/add_underline_menu_button
...
feat(editor): Underline markup for posts+comments
2020-01-28 22:34:30 +01:00
mattwr18
abeb2e97ed
Merge pull request #2871 from Human-Connection/fix-avatar-issues
...
fix(webapp): 🐛 Adjust Avatar Sizes and 'z-index'
2020-01-28 01:09:55 +01:00
mattwr18
d6a2f2d9e3
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1680-Direct_answer_on_Comment
2020-01-27 20:08:37 +01:00
Alina Beck
c74eebfcdc
use $event instead of event in vue template
2020-01-27 19:25:46 +01:00
Alina Beck
73a1d54915
remove z-index from UserAvatar
2020-01-27 19:17:22 +01:00
mattwr18
36130d9d7c
Check that stubbed component method is called
2020-01-27 13:44:40 +01:00
roschaefer
789c40c34e
feat(editor): Underline markup for posts+comments
...
We had tiptap's underline and never used it. A user has asked for it, so
why not implement it right away?
Suggested by `@raimundo@human-connection.social`:
https://human-connection.social/post/612bf465-91ce-4be8-906e-3bde63617346/hcsocial-dein-netzwerk-news-mit-dennis-and-robert-1#commentId-b864d04f-1e8c-48c4-9ed0-98aefaed1c02
2020-01-26 20:39:52 +01:00
Wolfgang Huß
9a8720218f
Implement suggestions of Matt
2020-01-24 19:35:01 +01:00
Wolfgang Huß
7eeddf2a8f
Implement suggestions of Matt
2020-01-24 19:23:01 +01:00
Mike Aono
d49afc25cf
test(cypress): Cover "Pinned post" feature
...
* Implement cypress tests
- Start implementation of cypress tests for pinned posts
* Test that Admin can pin a post
- Tests the process of an admin pinning a post
* Resolve failing tests
- Fix ordering of posts immediately after pinning posts by reloading page
- Check that tests are pinned posts are displayed first for role user
* Refactor to seperate the initialization
- Of the post data created in the database during setup
* Fix toaster test
* test(cypress): Add missing parts for pin feature
* docs(cucumber): Link to admin 🥒 folder
* Follow @mattwr18's suggestions
* test(backend): Order pinned posts like frontend
@mattwr18 I think this was a false negative.
Co-authored-by: Robert Schäfer <git@roschaefer.de>
2020-01-23 20:30:12 +01:00
mattwr18
bbb4dd56cd
Follow review suggestions/add button to unblock
...
- @roschaefer gave several suggestions
- we have a button to unblock/unmute users on profile page
2020-01-23 19:18:12 +01:00
mattwr18
853ff9b92b
Stub component, rename component, refactor
...
- We need to stub the Editor since it throws difficult to interpret
errors about view.root.getSelection, but we want to stub it's methods
as well, so that we don't need a guard clause just for tests.
- CommentForm is already multiword
- Favor update over result for Vue apollo smart queries
2020-01-23 14:03:14 +01:00
mattwr18
d15037607c
Add component test for direct reply to comment
...
- we have found it challenging to add component tests that mount the
tiptap editor, so we are stubbing it, which means that we will add e2e
tests to up the coverage of how much of the workflow has automated tests
2020-01-23 13:05:36 +01:00
Alina Beck
7c090cc3ed
set z-index for UserTeaser only on PostCard
2020-01-22 18:09:44 +03:00
Alina Beck
0392826211
set avatar size to small in AvatarMenu and for Anonymous users
2020-01-22 18:05:00 +03:00
Wolfgang Huß
58a120d3d7
Clean up
2020-01-22 15:13:13 +01:00
Wolfgang Huß
1c0d54a935
Fix lint
2020-01-22 13:34:52 +01:00
Wolfgang Huß
0bb2b905ee
Add example notification for filed report to storybook
2020-01-22 13:32:54 +01:00
Wolfgang Huß
e563887022
Fix test in 'NotificationsTable.spec.js' for new 'user-teaser' component
2020-01-22 13:17:11 +01:00
Wolfgang Huß
71cf2a397a
Modify layout of notifications menu
2020-01-22 13:02:54 +01:00
Alexander Friedland
9776efe760
Merge branch 'master' into 1680-Direct_answer_on_Comment
2020-01-22 11:46:04 +01:00
ogerly
21fa211e0c
test: specs not ok, lint is ok
2020-01-22 11:31:23 +01:00
ogerly
00c0397919
test: specs is not ok
2020-01-22 11:25:44 +01:00
Wolfgang Huß
4c6c3b8b27
Change the class 'text-notification-header'
2020-01-22 10:55:15 +01:00
Wolfgang Huß
2d73a54819
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1709-send-feedbacks-in-report-processes
...
# Conflicts:
# webapp/components/Notification/Notification.vue
# webapp/components/NotificationsTable/NotificationsTable.vue
2020-01-22 10:12:35 +01:00
mattwr18
e639358557
Test drive to get the functionality how we'd like
2020-01-21 21:16:42 +01:00
mattwr18
704b8c2d57
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1724-block-users
2020-01-21 21:15:03 +01:00
mattwr18
769c0cd105
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 2675-migrate-avatar-component-2
2020-01-21 17:08:51 +01:00
mattwr18
8fe6ad77e0
Merge pull request #2686 from Human-Connection/279-blacklist-users-content
...
feat: Convert block/unblock to mute/unmute
2020-01-21 17:05:09 +01:00
Alina Beck
24898f5fe2
quick fix tests relying on classes of child components
...
changing class names in the UserTeaser leads to tests failing for other components, like SearchableInput and NotificationsTable – I just updated the classes but long-term it would be good to find a way to not rely on implementation details of child components – maybe just test if the child component is rendered?
2020-01-21 17:07:00 +03:00
Alina Beck
287e9ce484
remove unused trunc prop
2020-01-21 17:00:37 +03:00
Alina Beck
e93332b173
display username below slug when there is no date-time
2020-01-21 17:00:20 +03:00
Alina Beck
d20421cb70
clean up UserAvatar a little
2020-01-21 13:26:14 +03:00
Alina Beck
c5af2dbfb4
truncate overflowing user name
2020-01-21 11:58:54 +03:00
Wolfgang Huß
4ca18522f1
Implement the filed report notification on the notification page
...
- Get all the old tests running.
- Implement new necessary tests.
- Lint fixing.
2020-01-20 18:03:40 +01:00
ogerly
73b005a900
test: added some test
2020-01-20 11:18:35 +01:00
Wolfgang Huß
48403471d5
Add tests in Notification.spec.js
2020-01-20 10:29:46 +01:00
mattwr18
7b73c990ec
Remove unintended changes to class name/comment
2020-01-20 10:19:39 +01:00
mattwr18
1da872ba1e
Update SearchableInput spec after rebase
2020-01-20 10:11:48 +01:00
mattwr18
77ef3b0406
Fix failing tests
2020-01-20 10:07:02 +01:00