Hannes Heine
34ba9d8c0b
Lint over the frontend code.
2020-08-07 14:07:53 +02:00
Hannes Heine
def6a9d444
Changed the class to use this.post.comments instead of the computed postComments so that issue are fixed.
2020-08-07 13:17:14 +02:00
Hannes Heine
7f8be5deab
fix : #3357 now the comment deletion and comment updates are seen directly after the event is triggered.
2020-08-06 16:18:27 +02:00
Hannes Heine
084a5172e9
Linter on webapp
2020-08-03 18:53:20 +02:00
Hannes Heine
fe999776c0
Filter out the deleted comments of the comment counter
2020-08-03 15:09:33 +02:00
roschaefer
276ea79e8f
Update prettier to v2
2020-03-24 21:11:11 +01:00
Alina Beck
701564c708
Merge branch 'master' into migrate-styleguide-card
2020-02-20 00:37:07 +01:00
roschaefer
f2e2db0bc7
fix(frontend): error when post.author null
2020-02-19 10:49:08 +01:00
Alina Beck
d2148bdd47
Merge branch 'master' into migrate-styleguide-card
2020-02-03 19:23:22 +01:00
mattwr18
c8c71a52c6
Follow @Tirokk PR review suggestions
...
- Favor lowercase for words in a sentence after the first
- Use exclamation marks for successful actions that use a toastr
- place events at the end of the list on components
- place class above events
- it would be nice to come to a consensus based on best practices, like
I had a doubt and places the class definition below the props, is that
what others do?
2020-01-31 13:09:37 +01:00
Alina Beck
38eec0fc5f
rename Comment to CommentCard
2020-01-22 17:43:25 +03:00
Alina Beck
e7bf499d37
use BaseCard in Comment component and refactor
2020-01-22 17:37:32 +03:00
ogerly
21fa211e0c
test: specs not ok, lint is ok
2020-01-22 11:31:23 +01:00
ogerly
73b005a900
test: added some test
2020-01-20 11:18:35 +01:00
mattwr18
3132ac14a1
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1680-Direct_answer_on_Comment
2020-01-16 12:16:15 +01:00
Alina Beck
150d04080b
follow @mattwr18 code review
2020-01-15 11:55:27 +03:00
ogerly
9d09dae2f4
slug from editor comands set
2020-01-14 18:36:35 +01:00
Alina Beck
7568837963
refactor counter icon
2019-12-17 18:13:53 +05:30
mattwr18
a8a9abb4e4
Refactor/Add new components
2019-11-29 14:02:53 +01:00
Alina Beck
4e6572a042
replace ds-icon with base-icon
2019-11-19 12:26:07 +03:00
mattwr18
6d1044d292
Hide new CommentForm while editing a comment
2019-10-21 16:08:01 +02:00
roschaefer
6a50ef6134
fix: storybook story of Comment.vue
...
This is the best solution that I can think of right now. Sure, it's not
so great to pass a property down from the page component. But at least
it fixes the storybook story, which is something.
2019-10-16 01:14:32 +02:00
roschaefer
9da40c4895
fix: avoid many scrollTo calls for n components
...
Thank you @vbelolapotkov for pointing out the flaws here:
https://github.com/Human-Connection/Human-Connection/pull/1756#discussion_r329361572
So here is my attempt to fix it:
* Install `vue-scrollto` which relies on `requestAnimationFrame`
- apparently this is better on Safari and IE? 🤔
- Mocking out entire modules is easier in jest:
https://jestjs.io/docs/en/bypassing-module-mocks
* Require `checkAnchor` to be implemented on the component
2019-10-01 11:55:18 +02:00
Vasily Belolapotkov
2c705a8680
sync with master to resolve merge conflicts
2019-09-29 20:33:39 +03:00
roschaefer
57598df228
refactor: re-use @vbelolapotkov's solution
...
If we make this a mixin, we can re-use the same solution for e.g. the
comment. If sb. notifies you, the browser automatically scrolls to the
comment in which you have been mentioned.
2019-09-29 14:28:38 +02:00
mattwr18
ee99673cec
Add Comment story, add spacing above user info
2019-09-25 08:26:24 +02:00
Vasily Belolapotkov
50feeed8bf
fix the bug with scrolling post comments into view
2019-09-24 12:47:42 +03:00
Alina Beck
3026b923e0
use translated title for comment list
2019-09-23 21:08:20 +01:00
Alina Beck
7104896150
remove sleep icon from comment list
2019-09-23 20:46:41 +01:00
mattwr18
0430ab0f74
Fix styling issue in comments list
...
- add back class comments which adds spaces between comments
2019-09-19 15:57:57 +02:00
mattwr18
b1003d8685
Disable tests because of difficulty testing tiptap
2019-09-18 08:56:41 +02:00
Wolfgang Huß
2c732bfbfb
Refactor create and update comment to emit events
2019-09-09 15:53:50 +02:00
roschaefer
491a626031
Replace deleteComment with a more KISS solution
2019-09-03 21:28:29 +02:00
Matt Rider
dbaa8e687f
Fix vue warnings, fix tests, refactor
...
- was throwing an error when trying to update commentsCount because of new implementation by @roschaefer which uses countResolver, but there was no related for commentsCount, it was r... also commentsCount is no longer needed anywhere in the code base, it is commentedCount now
2019-08-16 13:28:55 +02:00
