Robert Schäfer
3c22a432e6
Fix lint
2019-05-21 03:08:32 +02:00
Robert Schäfer
9dd35a887a
Fix test
2019-05-21 02:07:43 +02:00
Robert Schäfer
2a22aaa907
Fix edge case bug in extractIds
2019-05-21 02:01:00 +02:00
Robert Schäfer
2b03b515e2
Implement image upload for posts
2019-05-21 02:01:00 +02:00
Robert Schäfer
d624a3f232
Write tests for fileUpload
2019-05-21 02:01:00 +02:00
Robert Schäfer
4dbf1b2a2c
UpdateUser with avatarUpload
...
This is a curl request from a folder where I have a file `avatar.jpg`:
```
curl localhost:4000/ \
-F operations='{ "query": "mutation($id: ID!, $file: Upload) { UpdateUser(id: $id, avatarUpload: $file) { id name avatar } }", "variables": { "id": "u3", "file": null } }' \
-F map='{ "0": ["variables.file"] }' \
-F 0=@avatar.jpg
```
It uploads the avatar to the public folder. We should
* Write tests
* Change the `user.avatar` url and send it to `/api` in the frontend
2019-05-20 20:35:33 +02:00
ALau2088
c76e18fae3
Merge remote-tracking branch 'upstream/master' into 552-update_comment
2019-05-19 09:30:11 -07:00
ALau2088
3fe8e9a288
552-update_comment
2019-05-18 23:42:17 -07:00
ALau2088
7ddbab83e9
552-update_comment
2019-05-18 23:32:24 -07:00
ALau2088
f7ef09acbf
add UpdateComment mutation
2019-05-18 18:20:43 -07:00
341baa5e3b
fixed lint rules
2019-05-18 15:43:26 +02:00
e3f9d1fe73
dependencies, fixes
2019-05-18 15:33:12 +02:00
b4e7b9c40f
dependencies
2019-05-18 15:31:03 +02:00
161921c911
fixes
2019-05-18 15:29:21 +02:00
c69e5915f1
backend pretier, more linting rules
2019-05-18 15:07:02 +02:00
Robert Schäfer
45694b0f89
Merge pull request #617 from Human-Connection/dependabot/npm_and_yarn/backend/node-fetch-2.6.0
...
Bump node-fetch from 2.5.0 to 2.6.0 in /backend
2019-05-17 22:41:15 +02:00
dependabot[bot]
4bc6363eff
Bump express from 4.16.4 to 4.17.0 in /backend
...
Bumps [express](https://github.com/expressjs/express ) from 4.16.4 to 4.17.0.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.16.4...4.17.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-17 04:48:14 +00:00
dependabot[bot]
f0272ef8ed
Bump node-fetch from 2.5.0 to 2.6.0 in /backend
...
Bumps [node-fetch](https://github.com/bitinn/node-fetch ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/bitinn/node-fetch/releases )
- [Changelog](https://github.com/bitinn/node-fetch/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.5.0...v2.6.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-17 04:47:39 +00:00
dependabot[bot]
45c64db90f
Bump neo4j-graphql-js from 2.4.2 to 2.6.0 in /backend
...
Bumps [neo4j-graphql-js](https://github.com/neo4j-graphql/neo4j-graphql-js ) from 2.4.2 to 2.6.0.
- [Release notes](https://github.com/neo4j-graphql/neo4j-graphql-js/releases )
- [Changelog](https://github.com/neo4j-graphql/neo4j-graphql-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/neo4j-graphql/neo4j-graphql-js/commits )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-14 21:15:12 +00:00
eb995d6ad4
Merge pull request #596 from Human-Connection/refactoring_validation_middleware
...
Refactoring validation middleware
2019-05-14 12:02:59 +02:00
Robert Schäfer
2d1daee23a
Don't document that we can set IDs in mutations
2019-05-13 12:44:47 +02:00
mattwr18
f724b483c0
Merge pull request #567 from Human-Connection/dependabot/npm_and_yarn/backend/apollo-server-testing-2.5.0
...
Bump apollo-server-testing from 2.4.8 to 2.5.0 in /backend
2019-05-10 21:01:18 -03:00
Matt Rider
a6cc634218
Merge branch 'master' of github.com:Human-Connection/Human-Connection into dependabot/npm_and_yarn/backend/apollo-server-testing-2.5.0
2019-05-10 14:09:43 -03:00
Matt Rider
595887d582
Merge branch 'master' of github.com:Human-Connection/Human-Connection into dependabot/npm_and_yarn/backend/graphql-14.3.0
2019-05-10 14:08:47 -03:00
Robert Schäfer
81a26e14ff
Fix test case, move spec to the right location
...
@ulfgebhardt : The reason why the test case was failing is pretty
obvious. You forgot to create a user that you want to update. If there
is no user to update, then you get an empty response.
@ulfgebhardt : I moved the spec also in the right directory. You're
testing resolvers, so that's where I moved the `.spec` file.
2019-05-10 17:34:05 +02:00
Robert Schäfer
47d7c615a5
Refactoring: Put all data validations in one place
...
@ulfgebhardt @mattwr18 @tirokk
Here's how I imagined the data validation middleware. If we roll our own
input validations I would suggest to put them all in one place.
@ulfgebhardt this commit is a great example of how tests can speed you
up: Since I can rely on existing tests, I don't have to check the validations
manually. With tests you can refactor with confidence! 👍
2019-05-10 17:13:54 +02:00
82570bef7f
Merge pull request #478 from Human-Connection/2019/kw15/User_can_change_its_username_to_emptystring
...
2019/kw15/user can change its username to emptystring
2019-05-09 15:01:54 +02:00
2cb8d793fb
removed failing test
2019-05-09 14:37:42 +02:00
Wolfgang Huß
46d3dc8588
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into 463-delete-socialMedia
2019-05-09 08:43:11 +02:00
7983a93fbd
Merge branch 'master' into 2019/kw15/User_can_change_its_username_to_emptystring
2019-05-09 08:26:53 +02:00
d6f423d845
Merge pull request #574 from Human-Connection/2019/kw19/codecov
...
2019/kw19/codecov
2019-05-08 23:55:20 +02:00
00d5c4fde5
ignore dist folder
2019-05-08 22:58:00 +02:00
63b7ded4b6
ignore test modules in coverage estimation
2019-05-08 22:42:33 +02:00
466a9584ea
backend test pattern
2019-05-08 20:43:13 +02:00
28c44f2781
corrected testMatch pattern, fixed backend coverage collection (?)
2019-05-08 20:16:18 +02:00
900dfb9693
renabled tests - it seems like the reports do not work very well
2019-05-08 20:04:55 +02:00
ec9b3607d8
compute coverage over all code
2019-05-08 19:52:04 +02:00
4092a8873b
overall coverage seems not to be reported..., removed parts of tests not the whole thing
2019-05-08 19:38:01 +02:00
12ec2b8683
fixed codecov report layout, disabled tests in front- & backend for testing - should fail
2019-05-08 19:13:09 +02:00
dependabot[bot]
13ed5024dd
Bump apollo-server-testing from 2.4.8 to 2.5.0 in /backend
...
Bumps [apollo-server-testing](https://github.com/apollographql/apollo-server ) from 2.4.8 to 2.5.0.
- [Release notes](https://github.com/apollographql/apollo-server/releases )
- [Changelog](https://github.com/apollographql/apollo-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/apollographql/apollo-server/compare/apollo-server-testing@2.4.8...apollo-server-testing@2.5.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-08 12:28:11 +00:00
dependabot[bot]
a07c4d15d7
Bump graphql from 14.2.1 to 14.3.0 in /backend
...
Bumps [graphql](https://github.com/graphql/graphql-js ) from 14.2.1 to 14.3.0.
- [Release notes](https://github.com/graphql/graphql-js/releases )
- [Commits](https://github.com/graphql/graphql-js/compare/v14.2.1...v14.3.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-08 12:28:05 +00:00
Wolfgang Huß
0ffbe567c7
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into 463-delete-socialMedia
2019-05-08 08:54:11 +02:00
dependabot[bot]
cf9799fb18
Bump apollo-server from 2.4.8 to 2.5.0 in /backend
...
Bumps [apollo-server](https://github.com/apollographql/apollo-server ) from 2.4.8 to 2.5.0.
- [Release notes](https://github.com/apollographql/apollo-server/releases )
- [Changelog](https://github.com/apollographql/apollo-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/apollographql/apollo-server/compare/apollo-server@2.4.8...apollo-server@2.5.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-08 04:54:22 +00:00
Robert Schäfer
099a5c9cf4
Remove obsolete docker-compose files
...
Since we moved to a monorepo, we have it in the top level folder.
2019-05-07 19:24:59 +02:00
dependabot[bot]
cce81a5ec0
Bump jest from 24.7.1 to 24.8.0 in /backend
...
Bumps [jest](https://github.com/facebook/jest ) from 24.7.1 to 24.8.0.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/compare/v24.7.1...v24.8.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-07 12:25:10 +00:00
Robert Schäfer
9ff8b34840
Merge pull request #543 from Human-Connection/dependabot/npm_and_yarn/backend/eslint-plugin-node-9.0.1
...
Bump eslint-plugin-node from 8.0.1 to 9.0.1 in /backend
2019-05-07 14:23:14 +02:00
Robert Schäfer
287a55db9f
Remove test case entirely
...
@ulfgebhardt when I write "Remove test case" I mean indeed removing all
the lines of code of that test case, not only disabling it. Commenting
out code *and pushing it to version control* is a strong anti-pattern. Why?
First, code comments get out of date quickly. "Never trust code comments".
Second: In our example here, it creates anxiety because other contributors might
believe there was a reason why the commented code exists.
Read:
* https://blog.codinghorror.com/coding-without-comments/
* https://www.nayuki.io/page/dont-share-commented-out-code
* https://softwareengineering.stackexchange.com/questions/1/comments-are-a-code-smell
2019-05-07 14:10:12 +02:00
Robert Schäfer
0637d97648
Merge remote-tracking branch 'origin/master' into 2019/kw15/User_can_change_its_username_to_emptystring
2019-05-07 14:09:10 +02:00
3d2ce3960c
added url of conversation
2019-05-07 14:01:43 +02:00
Robert Schäfer
be10691ed5
Merge pull request #547 from Human-Connection/dependabot/npm_and_yarn/backend/babel-jest-24.8.0
...
Bump babel-jest from 24.7.1 to 24.8.0 in /backend
2019-05-07 14:01:17 +02:00
