Moriz Wahl
4ce5bdd6fa
get most components working
2023-02-15 10:23:34 +01:00
Wolfgang Huß
50bdfb80e2
Change from require to import which now works again
2022-05-04 09:15:47 +02:00
Wolfgang Huß
634249b407
Fix the rest of the faker imports
...
- Some seems to work even the old way?!
2022-05-03 14:22:10 +02:00
Hannes Heine
823056b59e
Added the user that writes the comment to the authentication. Test reply to comment edited. Test update comment added. Test delete comment pending.
2020-08-11 16:01:42 +02:00
Hannes Heine
34ba9d8c0b
Lint over the frontend code.
2020-08-07 14:07:53 +02:00
Hannes Heine
def6a9d444
Changed the class to use this.post.comments instead of the computed postComments so that issue are fixed.
2020-08-07 13:17:14 +02:00
Hannes Heine
7f8be5deab
fix : #3357 now the comment deletion and comment updates are seen directly after the event is triggered.
2020-08-06 16:18:27 +02:00
Hannes Heine
d513fec7fe
Added test comment that is disabled and changes the test name so that we see that the test checks the comment count to ignore disabled and deleted comments.
2020-08-06 16:12:36 +02:00
Hannes Heine
084a5172e9
Linter on webapp
2020-08-03 18:53:20 +02:00
Hannes Heine
fe999776c0
Filter out the deleted comments of the comment counter
2020-08-03 15:09:33 +02:00
Hannes Heine
9be480add2
Added a deleted comment to the Test case
2020-08-03 15:08:57 +02:00
roschaefer
276ea79e8f
Update prettier to v2
2020-03-24 21:11:11 +01:00
Alina Beck
701564c708
Merge branch 'master' into migrate-styleguide-card
2020-02-20 00:37:07 +01:00
roschaefer
f2e2db0bc7
fix(frontend): error when post.author null
2020-02-19 10:49:08 +01:00
Alina Beck
f29d486da0
replace ds-card in CommentForm
2020-02-03 20:10:44 +01:00
Alina Beck
d2148bdd47
Merge branch 'master' into migrate-styleguide-card
2020-02-03 19:23:22 +01:00
mattwr18
c8c71a52c6
Follow @Tirokk PR review suggestions
...
- Favor lowercase for words in a sentence after the first
- Use exclamation marks for successful actions that use a toastr
- place events at the end of the list on components
- place class above events
- it would be nice to come to a consensus based on best practices, like
I had a doubt and places the class definition below the props, is that
what others do?
2020-01-31 13:09:37 +01:00
mattwr18
36130d9d7c
Check that stubbed component method is called
2020-01-27 13:44:40 +01:00
mattwr18
d15037607c
Add component test for direct reply to comment
...
- we have found it challenging to add component tests that mount the
tiptap editor, so we are stubbing it, which means that we will add e2e
tests to up the coverage of how much of the workflow has automated tests
2020-01-23 13:05:36 +01:00
Alina Beck
38eec0fc5f
rename Comment to CommentCard
2020-01-22 17:43:25 +03:00
Alina Beck
e7bf499d37
use BaseCard in Comment component and refactor
2020-01-22 17:37:32 +03:00
ogerly
21fa211e0c
test: specs not ok, lint is ok
2020-01-22 11:31:23 +01:00
ogerly
00c0397919
test: specs is not ok
2020-01-22 11:25:44 +01:00
ogerly
73b005a900
test: added some test
2020-01-20 11:18:35 +01:00
mattwr18
3132ac14a1
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1680-Direct_answer_on_Comment
2020-01-16 12:16:15 +01:00
Alina Beck
150d04080b
follow @mattwr18 code review
2020-01-15 11:55:27 +03:00
ogerly
9d09dae2f4
slug from editor comands set
2020-01-14 18:36:35 +01:00
Alina Beck
ad27404059
fix failing component tests
2019-12-19 12:48:13 +05:30
Alina Beck
7568837963
refactor counter icon
2019-12-17 18:13:53 +05:30
mattwr18
a8a9abb4e4
Refactor/Add new components
2019-11-29 14:02:53 +01:00
Alina Beck
77f4810ddc
set up global localVue
...
by setting up localVue with all required plugins (such as styleguide and vuex)
in a separate testSetup file we can avoid doing this individually in all component tests
the testSetup is executed before each test suite, so each test file gets a fresh
instance of localVue
2019-11-20 12:31:40 +03:00
Alina Beck
4e6572a042
replace ds-icon with base-icon
2019-11-19 12:26:07 +03:00
mattwr18
98e3bb40d5
Merge pull request #1906 from Human-Connection/add_storybook_stories_for_our_university_students
...
Add storybook stories for our university students
2019-10-22 11:58:17 +02:00
mattwr18
6d1044d292
Hide new CommentForm while editing a comment
2019-10-21 16:08:01 +02:00
roschaefer
72bbadd852
dosc: add comment list story
2019-10-16 12:16:38 +02:00
roschaefer
6a50ef6134
fix: storybook story of Comment.vue
...
This is the best solution that I can think of right now. Sure, it's not
so great to pass a property down from the page component. But at least
it fixes the storybook story, which is something.
2019-10-16 01:14:32 +02:00
Alina Beck
2090e3939b
add $route mock to Comment and CommentList spec
2019-10-15 16:07:09 +03:00
roschaefer
08e73747bd
refactor: set global defaults of vue-scrollto
2019-10-01 17:51:16 +02:00
roschaefer
db1bcdd3d2
refactor: register vue-scrollto in nuxt.config.js
...
This will allow us to use this.$scrollTo in components. I'm now also
using this in the mixin. With so many `this`s it gets horribly
difficult to properly test the mixin in isolation. So I decided to test
the mixin on the component directly.
2019-10-01 17:25:28 +02:00
roschaefer
9da40c4895
fix: avoid many scrollTo calls for n components
...
Thank you @vbelolapotkov for pointing out the flaws here:
https://github.com/Human-Connection/Human-Connection/pull/1756#discussion_r329361572
So here is my attempt to fix it:
* Install `vue-scrollto` which relies on `requestAnimationFrame`
- apparently this is better on Safari and IE? 🤔
- Mocking out entire modules is easier in jest:
https://jestjs.io/docs/en/bypassing-module-mocks
* Require `checkAnchor` to be implemented on the component
2019-10-01 11:55:18 +02:00
Vasily Belolapotkov
2c705a8680
sync with master to resolve merge conflicts
2019-09-29 20:33:39 +03:00
roschaefer
57598df228
refactor: re-use @vbelolapotkov's solution
...
If we make this a mixin, we can re-use the same solution for e.g. the
comment. If sb. notifies you, the browser automatically scrolls to the
comment in which you have been mentioned.
2019-09-29 14:28:38 +02:00
Vasily Belolapotkov
e1751347fc
fix failing client tests
2019-09-25 10:32:35 +03:00
mattwr18
ee99673cec
Add Comment story, add spacing above user info
2019-09-25 08:26:24 +02:00
Vasily Belolapotkov
50feeed8bf
fix the bug with scrolling post comments into view
2019-09-24 12:47:42 +03:00
Alina Beck
a85fab04b6
remove failing test because specs have changed
2019-09-23 22:38:13 +01:00
Alina Beck
3026b923e0
use translated title for comment list
2019-09-23 21:08:20 +01:00
Alina Beck
7104896150
remove sleep icon from comment list
2019-09-23 20:46:41 +01:00
mattwr18
c8a2b03e98
Add removeHtml function in comments tests
2019-09-23 10:04:15 +02:00
mattwr18
0430ab0f74
Fix styling issue in comments list
...
- add back class comments which adds spaces between comments
2019-09-19 15:57:57 +02:00
