23 Commits

Author SHA1 Message Date
mattwr18
90fa70e83d
Merge pull request #1282 from Human-Connection/count_from_0_to_0_by_default
Get rid of property warnings
2019-08-19 10:06:09 +02:00
roschaefer
aa52587f83 Get rid of property warnings
If we always choose `0` as the default value for `endVal` in case it is
not given (maybe apollo assigns null when the request is in flight) then
just make `0` the default.
2019-08-16 17:08:00 +02:00
Matt Rider
dbaa8e687f Fix vue warnings, fix tests, refactor
- was throwing an error when trying to update commentsCount because of new implementation by @roschaefer which uses countResolver, but there was no related for commentsCount, it was r... also commentsCount is no longer needed anywhere in the code base, it is commentedCount now
2019-08-16 13:28:55 +02:00
Robert Schäfer
b8c5db48a6 Implement prefix of image urls with a filter
Fix #820

Ok, so after I would have to use the same method in three different
locations (`<ds-card>` expects an `image` attribute but cannot render
entire components) I decided to implement the prefix of image urls with
a filter rather than a component. The downside of this is that we have
to add the filter on a lot of component tests. The benefit is less
components and hopefully less complexity.
2019-06-13 16:56:41 +02:00
Matt Rider
f732ff44d0 Merge branch 'master' of github.com:Human-Connection/Human-Connection into dependabot/npm_and_yarn/webapp/prettier-1.17.1-fix_incompatibility 2019-05-29 10:33:43 -03:00
Matt Rider
ff0b4b6867 Fix lint 2019-05-29 09:47:24 -03:00
Robert Schäfer
db9596e276 Replace HcAvatar where possible
We still have `<ds-avatar>` in the code. It's used for the social media
icons. I'll leave it as it is for now.
2019-05-28 15:20:24 +02:00
5202763dd8
frontend lint fixes 2019-05-23 19:40:39 +02:00
7095e38947
fixed post card design 2019-05-17 23:10:10 +02:00
Matt Rider
bb306cad49 Update other ds-avatar sizes 2019-05-10 10:30:02 -03:00
Matt Rider
c28c51d86f Merge branch 'master' of github.com:Human-Connection/Human-Connection into 586-deal-with-yarn-warn-due-to-invalid-size-prop 2019-05-10 10:20:23 -03:00
Robert Schäfer
6c5f529d85 Couple of corrections
@aonomike use computed properties when possible
2019-05-10 13:58:24 +02:00
Matt Rider
6e675c74d5 Update ds-avatar size to use small 2019-05-09 15:34:24 -03:00
Robert Schäfer
f27dca504b Refactor mixin with computed property
@ulfgebhardt I refactored the mixin because it's not enough code to
justify the additional complexity. If it's just two lines of code, I
find it the best solution to use a computed property.

You can use components and computed properties excessively, they tend to
be easier to maintain in the long run.
2019-05-06 22:59:25 +02:00
Robert Schäfer
ad111f5701 Double-check changed expectations, fix tests
See:
https://github.com/Human-Connection/Human-Connection/pull/478/files#r281267486

> We found the reason for it: If you have an exclamation mark in the schema e.g.
> email! and the response would e.g. expect the email for each User object, and
> the server does not have an email for the client, then the entire User object
> gets nullified.
2019-05-06 19:26:53 +02:00
ad05dcf735
frontend tests, backend tests 2019-05-02 17:47:34 +02:00
0be2891858
make email a required field for user, tests for front- & backend 2019-05-02 16:17:16 +02:00
senderfm
412b56cffe seperatet username from truncate 2019-04-24 17:45:38 +02:00
d8546da116
fixed new mixins folder 2019-04-19 12:12:01 +02:00
d986e086c4
use mixins instead of duplicate methods 2019-04-19 11:47:07 +02:00
3eb96a20b2
lint fixes 2019-04-17 15:21:08 +02:00
2efc77097f
match specification of Dennis - minimum 3 characters for username, no hint for user to change the username to "Anonymous", Toast error if userdata cannot be changed due to username restrictions, display "Anonymous" if no username is found in database (even tho this is against implemented rules) 2019-04-17 14:49:03 +02:00
54bfb17e31
tests for tag & category, directory refactoring, lint fixes,more 2019-04-12 11:00:54 +02:00