ogerly
948982682d
fails, fails, fails
2019-09-04 10:09:20 +02:00
Alexander Friedland
e618ff005d
Merge branch 'master' into C-1187-terms-and-conditions-confirmed-function
2019-09-04 06:42:40 +02:00
roschaefer
af8475f28e
Avoid unavailable posts in relatedContributions
2019-09-03 23:19:55 +02:00
roschaefer
2a544376a3
Delete post.image
...
In contrast to the other errors, it's better to send `null` for an
image. That way, the browser won't even try to load that url.
2019-09-03 23:19:55 +02:00
roschaefer
64268a1f3c
Add locations to seeds, fix shoutedByCurrentUser
2019-09-03 21:28:29 +02:00
roschaefer
00454c874c
Remove read-only attributes from posts mutations
...
For the comments, the fix is not that easy: They are still using
`neo4j-graphql-js` in the resolvers. And that library needs the input
params for the query builder.
See: https://github.com/Human-Connection/Human-Connection/issues/1454
2019-09-03 21:28:29 +02:00
roschaefer
672f19e6d1
More of @mattwr18's suggestions
2019-09-03 21:28:29 +02:00
roschaefer
bb3f419532
Refactor graphql queries and fix bug
...
It's sometimes unbelievable how many bugs you find when doing
refactoring. This time there was some apparent confusion about
`commentsCount` and `commentedCount`. The counters on the post card were
never showing the correct number.
2019-09-03 21:28:29 +02:00
roschaefer
7b44a87e3b
Follow @mattwr18's suggestions
2019-09-03 21:28:29 +02:00
roschaefer
0b3bbb1f14
Delete post.title and obfuscate slug
2019-09-03 21:28:29 +02:00
roschaefer
bd885b1aac
Delete emails and social media, bugfix
...
The bugfix was missing '(' plus a wrong order for the social media
relationship called 'OWNED_BY'.
2019-09-03 21:28:29 +02:00
roschaefer
2b83745f6b
You cannot login if your account is deleted
2019-09-03 21:28:29 +02:00
roschaefer
491a626031
Replace deleteComment with a more KISS solution
2019-09-03 21:28:29 +02:00
roschaefer
c4ba2c4aeb
SoftDeleteMiddleware obfuscates deleted resources
2019-09-03 21:28:29 +02:00
roschaefer
76acebbb73
Notifications query filters for deleted resources
...
This should finally fix #1414
2019-09-03 21:28:29 +02:00
roschaefer
660e3434aa
Implement delete of comments when post is deleted
2019-09-03 21:28:29 +02:00
roschaefer
1b5d91bfd2
Refactor post spec, implement soft delete, fix bug
...
I think the validation for categories was too complex and the graphql
query 'PostEmotionsByCurrentUser' was erroneously allowed for
unauthenticated users.
2019-09-03 21:28:29 +02:00
roschaefer
2033b1791c
Fix posts resolver spec
2019-09-03 21:28:29 +02:00
roschaefer
3f5ac61b73
Fix users and report resolver specs
...
This time I did not refactor the whole tests suites because of time and
complexity of the PR review.
2019-09-03 21:28:29 +02:00
roschaefer
0f64bbb71f
Soft delete for comments implemented
2019-09-03 21:28:29 +02:00
roschaefer
4bfc0ff2bf
Refactor comments.spec, refactor post factory
2019-09-03 21:28:29 +02:00
Alexander Friedland
41767cc27e
Merge branch 'master' into C-1187-terms-and-conditions-confirmed-function
2019-09-03 09:51:12 +02:00
ogerly
1b9303ceaf
Jest tests for the Terms and Conditions in frontend and backend
2019-09-03 09:46:18 +02:00
roschaefer
cbcba8f08d
Follow @Tirokk 's suggestion
2019-08-30 16:00:32 +02:00
roschaefer
bf6e7a8131
Implement fallback resolvers for Post and Comment
2019-08-30 16:00:32 +02:00
roschaefer
9b2c707aa3
DRY notifications resolver
2019-08-30 16:00:32 +02:00
roschaefer
3f121c7c4d
Refine notification behaviour:
...
If you mark a post or comment as read even though you already marked the
corresponding notification as read, then you receive `null`.
2019-08-30 16:00:32 +02:00
roschaefer
2846a6a8d3
Spec for notifications passing
2019-08-30 16:00:32 +02:00
roschaefer
cf8ead10f3
Start to refactor backend tests
2019-08-30 16:00:32 +02:00
roschaefer
4b96454b90
Notifications resolver capable of orderBy + filter
2019-08-30 16:00:32 +02:00
roschaefer
643d175ef6
Implement notifications resolver
2019-08-30 16:00:32 +02:00
Robert Schäfer
0a5052ba96
Merge pull request #1397 from Human-Connection/performance-improvement
...
Check there are ids in the badIds array
2019-08-30 14:08:13 +02:00
Matt Rider
42018f0bf4
Merge branch 'master' of github.com:Human-Connection/Human-Connection into performance-improvement
2019-08-30 07:17:19 +02:00
ogerly
ee03f0e902
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into C-1187-terms-and-conditions-confirmed-function
2019-08-28 14:21:46 +02:00
roschaefer
e4d57f80aa
Fix #1333
...
Ok, so here are multiple issues:
1. In cypher, `NOT NULL` will return `NULL` not `FALSE`. If we want
`FALSE` to be set in the database import, we should use `COAELESCE`
to find the first not-null value.
See:
https://neo4j.com/docs/cypher-manual/current/syntax/working-with-null/
https://markhneedham.com/blog/2017/02/22/neo4j-null-values-even-work/
2. I removed the `disabled` and `deleted` checks on the commented
counter. With `neo4j-graphql-js` it is not possible to filter on the
join models (at least not without a lot of complexity) for disabled or
deleted items. Let's live with the fact that the list of commented posts
will include those posts, where the user has deleted his comment or where
the user's comment was disabled. It's being displayed as "not available"
so I think this is OK for now.
3. De-couple the pagination counters from the "commented", "shouted"
etc. counters. It might be that the list of posts is different for
different users. E.g. if the user has blocked you, the "posts" list
will be empty. The "shouted" or "commented" list will not have the
posts of the author. If you are a moderator, the list will include
disabled posts. So the counters are not in sync with the actual list
coming from the backend. Therefore I implemented "fetch and check if
resultSet < pageSize" instead of a global counter.
2019-08-28 12:57:32 +02:00
Matt Rider
6de602fd58
Revert @roschaefer 's hacky fix to Search.feature
...
- now that we are checking to see if there are any badIds, it was breaking the search functionality
2019-08-26 21:37:36 +02:00
Matt Rider
b990a1055b
Fix search functionality
...
- remove unused line that allows for an empty array of author_not.id_in
2019-08-26 17:51:44 +02:00
roschaefer
9f6757f409
Use guard clauses if possible
2019-08-26 16:53:22 +02:00
Matt Rider
75d984073d
Check there are ids in the badIds array
...
- if there are no ids, we shouldn't add an empty array since it adds unneccessarily to our auto-generated post query and affects greatly performance. see issue #1390
2019-08-26 16:19:42 +02:00
Wolfgang Huß
df4f0627b5
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into 1062-notification-about-comment-on-post
...
# Conflicts:
# backend/src/middleware/index.js
2019-08-23 15:31:48 +02:00
Matt Rider
cd5e492569
Await relation be added
2019-08-23 12:18:53 +02:00
ogerly
53532025d6
Fix translation add backend test case todo
2019-08-23 11:36:41 +02:00
ogerly
0bb71cfbb3
Specs tests run through cleanly
2019-08-23 11:02:24 +02:00
ogerly
36ce6361ec
Alle Daten übernommen die für serverseitig rendern nötig sind
2019-08-23 11:02:24 +02:00
Matt Rider
773779e5f1
Fix UpdatePost resolver/validations
2019-08-23 10:57:11 +02:00
Wolfgang Huß
04fe6b0a8c
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into 1062-notification-about-comment-on-post
...
# Conflicts:
# backend/src/middleware/handleNotifications/handleNotificationsMiddleware.spec.js
Refactored there tests a little
2019-08-22 11:02:10 +02:00
Wolfgang Huß
d98ebdd713
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into 1062-notification-about-comment-on-post
2019-08-21 08:37:43 +02:00
Matt Rider
512bf32b0c
Update cypress tests, fix broken comment reactivity
2019-08-20 21:27:00 +02:00
Matt Rider
8735045d11
Update cypress tests, post query
2019-08-20 20:13:29 +02:00
Matt Rider
a000719663
Merge branch 'master' of github.com:Human-Connection/Human-Connection into post-needs-to-have-category#1222
2019-08-20 16:13:38 +02:00