Matt Rider
ad46c2d059
Remove cypress test
...
- it is not part of the scope of this ticket, and therefore should be extracted and dealt with separately
2019-05-05 12:26:02 -03:00
Matt Rider
1fff9bbc46
Add cypress test to expose comment creation bug
...
- at the moment, one can create the same comment by clicking rapidly on the "Comment" button
- an idea for a fix https://stackoverflow.com/questions/53101521/prevent-repeated-queries-in-apollo-server-2
2019-05-04 18:46:34 -03:00
Matt Rider
70fb34345d
Improve test by mounting CommentList with data
2019-05-03 15:53:16 -03:00
Matt Rider
da218f8a58
Add component test for extracted CommentList.vue
2019-05-03 15:48:20 -03:00
Matt Rider
d1c8682710
Update method name to be more descriptive/accurate
2019-05-03 15:47:54 -03:00
Matt Rider
ebc290c6af
Delete CommentForm.test.js, remove console.log
...
- this test is not part of this PR and I'll create another issue and put in a different PR for it
2019-05-03 13:39:43 -03:00
Matt Rider
957d894322
Start writing component test
...
- restructured directories
2019-05-03 11:18:14 -03:00
Matt Rider
40f5b6acd5
Extract CommentsList component
...
- this allows to Query for comments by Post
2019-05-02 21:03:31 -03:00
Matt Rider
1b84ccbdfa
Update to allow single character comments or greater
2019-04-29 12:19:27 -03:00
Matt Rider
30d0ff3cc7
Search for button with text "Comment" in cypress test
2019-04-26 11:31:18 -03:00
Matt Rider
5891129662
Ordered comments like alpha, move HcCommentForm, mobile responsive
...
- in the first instance, we will be importing posts/comments from the alpha, so to maintain consistency, we've ordered them alike. In the future, we could support user choice of order.
- Gives more space for HcCommentForm, user can see comments added to list, helps with mobile responsiveness
Co-authored-by: Tirokk <wolle.huss@pjannto.com>
Co-authored-by: Mike Aono <aonomike@gmail.com>
2019-04-26 08:57:29 -03:00
Matt Rider
05ad8ccc30
Remove unused variable/method
2019-04-25 16:36:59 -03:00
Matt Rider
c387760046
Extract CommentForm component
...
- Cypress test is now passing as a result
Co-authored-by: Tirokk <wolle.huss@pjannto.com>
2019-04-25 14:20:00 -03:00
Matt Rider
092dcd7122
Get cypress test passing in a hacky way
2019-04-25 10:10:08 -03:00
Matt Rider
7fafa1eb6e
Get clear working properly
2019-04-24 20:56:15 -03:00
Matt Rider
8ae632be7b
Fix component test, comment out form submission from cypress
...
- Added $t function to test now that it is being localised
- We are submitting the form by clicking on the button as a normal user would
- Cypress test still broken due to peculiarities of tiptap editor
2019-04-24 12:28:53 -03:00
Matt Rider
546e2c99ad
Localise text, remove frontend validations
...
- validations are not working for the editor, they only work for our ds-input
2019-04-24 09:15:41 -03:00
Robert Schäfer
6c37f525c5
Grey out a read notification + test it
2019-04-18 17:11:22 +02:00
Robert Schäfer
9a96f22870
Finish Mention.feature 🥒
2019-04-17 22:29:55 +02:00
Robert Schäfer
055b79bfe2
RemoveLinks is better suited as a filter
...
Unfortunately with `v-html` you cannot use filters directly in
handlebars.
See: https://github.com/nuxt/nuxt.js/issues/231
I also fixed the tests even **without** mocking vue-filters.js plugin 👍
2019-04-17 01:54:53 +02:00
Robert Schäfer
e595135e9d
Display post.createdAt along with Notification
2019-04-17 01:18:53 +02:00
Robert Schäfer
f5afdf2435
Merge Notification with NotificationPostCard
...
cc @mattwr18 Please don't see this as a revert of your work. Your
structure of the `notification-post-card` component was helpful and showed
the redundancy with `hc-post-card`. I reused a lot of the code, but
because I merged both components it now *looks* as if I authored all the code.
2019-04-17 01:10:17 +02:00
Robert Schäfer
00046a5429
Remove obsolete href method
2019-04-17 00:08:39 +02:00
Robert Schäfer
c4577aa3e8
Move mixins to the right place
2019-04-17 00:08:39 +02:00
Robert Schäfer
4f2e70e871
Refactor and harden PostCard component
2019-04-17 00:08:21 +02:00
Robert Schäfer
128480fd0e
Implement first test for Notification
...
Fixed a bug along the way `(post.contentExcerpt == null)`
2019-04-17 00:08:21 +02:00
Robert Schäfer
af60ad39a4
Follow directory layout
2019-04-17 00:08:21 +02:00
Robert Schäfer
9ed204fa72
Open mentioning link in new tab
...
This will help some people not to loose data after accidently clicking
on the user @-mentioning.
2019-04-17 00:08:21 +02:00
Robert Schäfer
dd1d86e02c
Use slugs instead of names for mentions
2019-04-17 00:08:21 +02:00
Robert Schäfer
25bef85683
Order users by name
2019-04-17 00:08:21 +02:00
Robert Schäfer
d885fd1beb
Move ContributionForm in dedicated folder
2019-04-17 00:08:21 +02:00
Robert Schäfer
fcafb4e105
Fix lint
2019-04-17 00:08:21 +02:00
Robert Schäfer
bf18754b4d
Customize Mention node based on Superclass
2019-04-17 00:08:21 +02:00
Robert Schäfer
b5f60369a5
Follow file naming convention
...
All components should consist of a folder with these three files:
```
README.d
index.vue
spec.js
```
When you import components, omit the `index.vue`. That helps to `git
grep` for component names.
2019-04-17 00:08:21 +02:00
Robert Schäfer
4d9c6c5b1c
Pass entire user collection to Editor
2019-04-17 00:08:21 +02:00
Robert Schäfer
7d3b1ea3cc
Copy+paste from tiptap example
...
See https://github.com/scrumpy/tiptap/blob/master/examples/Components/Routes/Suggestions/index.vue
2019-04-17 00:08:21 +02:00
Robert Schäfer
5f456fe752
Scaffold test for Editor.vue
2019-04-17 00:08:21 +02:00
Matt Rider
d4a4c9f362
Fix failing tests
2019-04-15 19:49:42 -03:00
Matt Rider
7102618569
Merge github.com:Human-Connection/Human-Connection into 347-display_notifications
2019-04-15 19:38:13 -03:00
Matt Rider
e4908ed640
Add component for Notifications' posts, style
2019-04-15 19:33:27 -03:00
Robert Schäfer
d3ff3ca241
Merge remote-tracking branch 'origin/master' into 342-merge_documentation
2019-04-12 14:48:27 +02:00
34faf9b8b3
missing test case 'gibberish' for RelativeDateTime
2019-04-12 11:16:45 +02:00
54bfb17e31
tests for tag & category, directory refactoring, lint fixes,more
2019-04-12 11:00:54 +02:00
b7228648fc
fixed tests (missing dependency), fixed relativeDateTime language
2019-04-12 10:05:43 +02:00
mattwr18
4383431260
GitBook: [342-merge_documentation] 56 pages and 14 assets modified
2019-04-11 22:12:37 +00:00
Robert Schäfer
d58076d0ff
Consistency: Filename equals name of component
2019-04-10 18:53:46 +02:00
Robert Schäfer
79b29b25aa
Check if String is accepted, too
2019-04-10 18:50:52 +02:00
Robert Schäfer
a7354a054e
Fix test, remove vue-filter relativeDateTime
...
cc @Tirokk @ulfgebhardt @appinteractive
This is a perfect example why I insist on writing tests. While debugging
@Tirokk and I discovered several design flaws and plugins that depend on
each other. The solution to all of this is not to use vue-filters plugin
at all! Vue-filters depends on Vuex, i18n, vuex-i18n, nuxt-modules and so
on.
This is just bad, bad, bad code. Start writing tests. Now.
We should start to refactor vue-filters and use components instead.
2019-04-10 18:46:13 +02:00
Wolfgang Huß
68f0dde62f
Refactored RelativeDateTime
...
Removed timeouts for the sake of simplicity
2019-04-10 17:29:03 +02:00
Wolfgang Huß
cc05ea11b5
Removed the responsability of the component "RelativeDateTime" to know if it is rendered in a browser
...
cc @ulfgebhardt
2019-04-10 16:46:32 +02:00