Robert Schäfer
c9e6d182ec
Followed @mattwr18's suggestions here:
...
https://github.com/Human-Connection/Human-Connection/pull/952#pullrequestreview-269406016
2019-08-01 12:20:33 +02:00
Robert Schäfer
72edf78889
Meld a chaotic commit history into one commit
...
Some important commit messages:
```
Fix youtu.be not being embedded
And also try to maintain the old behaviour matching
`provider.provider_url`.
```
```
Remove confusing code comments and obsolete code
I discovered that the behaviour of no duplicate notifications being send
out is caused by the frontend: When the editor reads html from the
backend, it will parse hashtags and mentions as ordinary links, not as
their respective nodes during editing. Also, we don't have to worry
about duplicate ids being found: The cypher statement will implicitly
suppress duplicate notification nodes for the same user.
So let's remove the code to avoid confusing the next developer.
```
```
Test editor.getHTML()
I do this because I'm not able to test the content of `this.editor` from
a wrapper of `vue-test-utils`. If I call `this.editor.getHTML` directly
and use it as a computed property `renderedContent` to populate a `<div
v-html="renderedContent" />` this will not work for the embeds. So, my
current best bet is to test the editor object isolated from a real
component. ;(
```
```
Add core-js as explicit dependency
Because of build errors on Travis.
See: https://stackoverflow.com/a/55313456
Remove as soon as this issue is resolved:
https://github.com/storybookjs/storybook/issues/7591
```
```
Refactor: Keep Runtime-only builds
See: https://vuejs.org/v2/guide/installation.html#Runtime-Compiler-vs-Runtime-only
```
2019-08-01 00:28:22 +02:00
Wolfgang Huß
a542b33f79
Merge pull request #1053 from Human-Connection/refine-social-media
...
🍰 Refine social media
2019-07-29 16:08:08 +02:00
Alina Beck
b16a98f1aa
mark backend auth tests as todo
2019-07-23 14:58:11 +02:00
Alina Beck
59321ec8f4
add more thorough backend tests (wip)
2019-07-23 14:54:11 +02:00
Alina Beck
cb33d0c267
rename social media mutations in backend tests
2019-07-23 12:09:35 +02:00
Robert Schäfer
4ee20d4e7e
Coerce undefinedToNull in embed resolver
2019-07-22 00:38:56 +02:00
Robert Schäfer
c5789cbf90
Fix get-video-id expects a string bug
2019-07-22 00:20:43 +02:00
Robert Schäfer
657a5ac1f5
Fix resolve function returns undefind
...
I'm also trying to make sense of the attribute `sources` - probably it's
indicating where the data is coming from.
2019-07-21 23:31:44 +02:00
Robert Schäfer
3d7a30d419
Remove metascraper-logo-favicon altogether
...
It's doing http requests which are hard to test and hard to maintain.
Therefore let's remove it until we really need it.
2019-07-21 22:20:44 +02:00
Robert Schäfer
75743cae32
Passing jest test, not all requests stubbed out
2019-07-21 13:41:39 +02:00
Robert Schäfer
579ec7e7dc
Re-add embed attribute as html
2019-07-20 17:51:20 +02:00
Robert Schäfer
f5730fce7e
Start to mock+test embeds resolver
...
+ Put oembed providers into a file
+ Add test snapshots
+ Remove unnecessary request-native dependency
2019-07-20 17:47:18 +02:00
Robert Schäfer
d81c38c4e3
Remove obscure embed attribute and remove cache
...
The cache is a possible memory leak: It grows over time and never gets
cleaned.
2019-07-20 15:58:55 +02:00
Robert Schäfer
73e879eb68
Fix lint
2019-07-19 22:29:53 +02:00
Robert Schäfer
f82b2c37b3
Refactor scraper.js with ES6 imports
2019-07-19 21:29:07 +02:00
Robert Schäfer
2e6ea62144
Replace got with node-fetch => -1 dependency
2019-07-19 21:06:05 +02:00
Robert Schäfer
d4c3b7ac10
Merge embed service with backend
2019-07-19 20:32:53 +02:00
Matt Rider
5fb89fd45c
Merge branch 'master' of github.com:Human-Connection/Human-Connection into refine-social-media
2019-07-17 07:23:29 -03:00
Wolfgang Huß
e0ab41a3d1
Merge pull request #788 from Human-Connection/552-update_comment
...
Update comment
2019-07-17 10:36:53 +02:00
Wolfgang Huß
f7da4a2bdf
Rewrite the Backend test that are doublets to make sense
2019-07-17 09:26:03 +02:00
Robert Schäfer
1970baaa2d
Apparently neode doesn't like multiple connections
...
Why? 😟
2019-07-16 21:05:44 +02:00
Robert Schäfer
95d26a701c
Fix lint
2019-07-16 21:00:47 +02:00
Robert Schäfer
99bfd56ea7
Merge remote-tracking branch 'origin/master' into refactor_email_address
2019-07-16 20:20:21 +02:00
Robert Schäfer
4c9dbdb378
Refactor changePassword resolver with neode
2019-07-16 20:06:26 +02:00
Matt Rider
1c53c58f42
Add backend validation tests to expose non-validation
...
- remove validation/index.js as it's not being used
- move validations to validationMiddleware.js where it validates
2019-07-16 14:54:13 -03:00
Matt Rider
a019c8c311
Revert unintended changes, refactor
...
- rename some variables in comments.spec.js while dealing with merge conflicts
- rename EditCommentForm/index.vue with new naming convention
- add comment to explain absense of <no-ssr>
- use a comments content for edit comment form content, not excerpt
2019-07-16 07:53:57 -03:00
Matt Rider
7de337f96d
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 552-update_comment
2019-07-16 07:24:23 -03:00
Wolfgang Huß
dded3344cc
Merge pull request #1040 from Human-Connection/remove_graphql_yoga
...
Remove graphql-yoga
2019-07-16 09:13:44 +02:00
Wolfgang Huß
b5bd77b539
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into 1000_find_users_by_email_address
...
# Conflicts:
# webapp/layouts/default.vue
2019-07-16 08:44:42 +02:00
Matt Rider
36c4a22b76
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 552-update_comment
2019-07-15 18:29:26 -03:00
Robert Schäfer
46cd21db1f
Fix registration.spec
2019-07-15 19:35:07 +02:00
Robert Schäfer
b8ab7cacef
Fix email filter test
2019-07-15 19:21:17 +02:00
Robert Schäfer
cec3eddcef
Fix more test cases
2019-07-15 18:35:38 +02:00
Robert Schäfer
88aa8a3929
Encrypt email in JWT - fixes 2 test cases
2019-07-15 18:35:38 +02:00
Robert Schäfer
dacc3bb557
Implement fallback User.email resolver
2019-07-15 18:35:38 +02:00
Robert Schäfer
46589362fa
Start to refactor User<->EmailAddress
2019-07-15 18:35:38 +02:00
Robert Schäfer
d59c94c9f3
Keep gql syntax highglighting
...
... with custom fake template string
2019-07-15 18:09:54 +02:00
Matt Rider
cf6ace59aa
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 967-filter-post-by-category
2019-07-15 11:34:42 -03:00
Wolfgang Huß
ea896f8b3a
Merge pull request #1039 from Human-Connection/bugfix_email_template
...
Bugfix: Signup email was missing email query param
2019-07-15 13:35:57 +02:00
Alina Beck
7217bb37a4
avoid duplicate social media urls
2019-07-15 13:30:40 +02:00
Matt Rider
8f17045cdb
Update tests to make more reliable
...
- hope you are ok with this @roschaefer , it was failing locally and I guess it passed the build because half the time the array is returned in the order expected while half the time not.
2019-07-15 07:33:22 -03:00
Robert Schäfer
0d06b78ad4
Merge pull request #1038 from Human-Connection/1037-refactor-comments-resolver-extract-out-validations
...
Refactor CreateComment resolver
2019-07-13 23:59:15 +02:00
Robert Schäfer
268ec332b4
Add a first test with apollo-server-testing
2019-07-13 19:26:57 +02:00
Robert Schäfer
f64a21bd01
Remove graphql-yoga
2019-07-13 19:26:56 +02:00
mattwr18
4c91d8fbc5
Merge pull request #1016 from Human-Connection/277_reward_badges
...
Refactor reward/unreward Badges in backend
2019-07-13 10:08:52 -03:00
Robert Schäfer
99740e6ad6
Follow @Tirokk 's suggestion and rename key=>id
2019-07-13 14:27:19 +02:00
Robert Schäfer
f9969b964c
Implement conditional filtering
2019-07-13 14:07:51 +02:00
Matt Rider
cc61dac818
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 967-filter-post-by-category
2019-07-12 10:50:14 -03:00
Robert Schäfer
2d4eec6a52
Bugfix: Signup email was missing email query param
2019-07-12 14:31:28 +02:00