Matt Rider
d511d6aa78
Refactor graphql queries
...
- Remove duplicate queries
- Use smart query in pages/post/_id/_slug/index.vue to avoid multiple db requests for a post and its comments.
We cannot update the apollo cache with asyncData and smart queries have a prefetch policy set to true by default, which
means that they will resolve in a similar timeframe. https://stackoverflow.com/questions/55885337/in-nuxt-should-i-use-asyncdata-or-default-apollo-queries
https://vue-apollo.netlify.com/api/smart-query.html#options
https://vue-apollo.netlify.com/guide/ssr.html#vue-cli-plugin
2019-08-16 11:25:53 +02:00
Matt Rider
36c4a22b76
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 552-update_comment
2019-07-15 18:29:26 -03:00
Matt Rider
b6dcafcc2b
Fix linting
2019-07-10 18:52:23 -03:00
Robert Schäfer
9a72e7b9e6
Proper null handling
...
FYI @mattwr18
2019-07-10 18:01:18 +02:00
ALau2088
912b94d43c
add EditCommentForm spec.js
2019-06-27 10:59:53 -07:00
ALau2088
5e9f46405e
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into 552-update_comment
2019-06-27 10:18:53 -07:00
Matt Rider
c6203ad8eb
Refactor CreateComments functionality
...
- update apollo cache on successful mutation
- remove global event listener
- avoid refetch Post to update CommentsList
- return comment with its author from resolver
2019-06-24 18:21:52 -03:00
senderfm
0a66ad56d9
Fix Specs, lint, fix test
2019-06-18 09:58:29 +02:00
Matt Rider
7d00b73530
Turn off $root listeners in beforeDestroy
2019-06-14 14:02:22 -03:00
ALau2088
22f166adac
merge upstream/552-update_comment
2019-06-08 15:55:51 -07:00
Wolfgang Huß
948a99d9da
Merge remote-tracking branch 'origin/master' into 553-delete-comment
...
# Conflicts:
# webapp/components/Modal/DeleteModal.vue
# webapp/components/PostCard/index.vue
# webapp/components/comments/CommentList/index.vue
# webapp/pages/index.vue
# webapp/pages/post/_id/_slug/more-info.vue
2019-06-03 10:39:13 +02:00
Wolfgang Huß
5bec0f1d72
Refined list deletion functions and started writing custom mutation for DeleteComment and their tests
2019-05-31 15:46:34 +02:00
Wolfgang Huß
3e3e447bc5
Refactored three quater of the tests
2019-05-29 17:59:07 +02:00
Matt Rider
f732ff44d0
Merge branch 'master' of github.com:Human-Connection/Human-Connection into dependabot/npm_and_yarn/webapp/prettier-1.17.1-fix_incompatibility
2019-05-29 10:33:43 -03:00
Matt Rider
ff0b4b6867
Fix lint
2019-05-29 09:47:24 -03:00
Wolfgang Huß
7807831e0e
Merge remote-tracking branch 'origin/master' into 553-delete-comment
2019-05-29 12:17:24 +02:00
Matt Rider
b378bcb286
Fix edit field render bug(CommentForm)
...
- remove no-ssr, which was not necessary and causing the edit field not to appear the majority of the times visiting a Post.
- this was really bad user experience since a user would need to refresh the page to comment.
- removed args in refetchPostComments as there are no params passed in when it is called anymore
- needed to add an if statement since if there are no comments on a Post, then this.$apollo.queries.Post is undefined and it errors out trying to call refetch()
- update test to remove no-ssr
Co-authored-by: Mike Aono <aonomike@gmail.com>
2019-05-27 17:02:00 -03:00
Wolfgang Huß
68980f85c6
Merge remote-tracking branch 'origin/master' into 553-delete-comment
...
# Conflicts:
# webapp/components/Comment.vue
# webapp/components/ContentMenu.vue
# webapp/components/Modal/DeleteModal.spec.js
# webapp/components/Modal/DeleteModal.vue
# webapp/components/Modal/DisableModal.spec.js
# webapp/components/Modal/DisableModal.vue
# webapp/components/Modal/ReportModal.spec.js
# webapp/components/Modal/ReportModal.vue
# webapp/components/PostCard/index.vue
# webapp/components/comments/CommentList/index.vue
# webapp/locales/de.json
# webapp/pages/index.vue
# webapp/pages/profile/_id/_slug.vue
2019-05-27 12:34:59 +02:00
ALau2088
8a8ed5131e
refactor backend and add UI
2019-05-24 08:03:39 -07:00
5202763dd8
frontend lint fixes
2019-05-23 19:40:39 +02:00
Wolfgang Huß
7f83f775a7
Clean up the delete-menu stuff for Comments and Posts
2019-05-19 08:23:51 +02:00
Wolfgang Huß
8033556145
Investigation how to update the Comments List intelligent
2019-05-18 07:35:45 +02:00
Matt Rider
d1c8682710
Update method name to be more descriptive/accurate
2019-05-03 15:47:54 -03:00
Matt Rider
957d894322
Start writing component test
...
- restructured directories
2019-05-03 11:18:14 -03:00