update README

Dockerfile

@@ -1,8 +1,5 @@
 FROM ruby:2.6.5-alpine
 
-RUN apk add --update nodejs
-
 COPY lib /action/lib
-COPY bin /action/bin
 
 CMD ["ruby", "/action/lib/index.rb"]

README.md

@@ -7,6 +7,7 @@ A GitHub Action that check minimum coverage percentage!
 #### Lcov
 
 ```yml
+- uses: actions/checkout@v1
 - uses: devmasx/coverage-check-action@v1.1.0
   with:
     type: lcov
@@ -18,6 +19,7 @@ A GitHub Action that check minimum coverage percentage!
 #### [Simplecov](https://github.com/colszowka/simplecov)
 
 ```yml
+- uses: actions/checkout@v1
 - uses: devmasx/coverage-check-action@v1.1.0
   with:
     type: simplecov

bin/lcov-parse.js

@@ -1,129 +0,0 @@
-/*
-Copyright (c) 2012, Yahoo! Inc. All rights reserved.
-Code licensed under the BSD License:
-http://yuilibrary.com/license/
-*/
-
-var fs = require('fs'),
-  path = require('path');
-
-/* istanbul ignore next */
-var exists = fs.exists || path.exists;
-
-var walkFile = function (str, cb) {
-  var data = [], item;
-
-  ['end_of_record'].concat(str.split('\n')).forEach(function (line) {
-    line = line.trim();
-    var allparts = line.split(':'),
-      parts = [allparts.shift(), allparts.join(':')],
-      lines, fn;
-
-    switch (parts[0].toUpperCase()) {
-      case 'TN':
-        item.title = parts[1].trim();
-        break;
-      case 'SF':
-        item.file = parts.slice(1).join(':').trim();
-        break;
-      case 'FNF':
-        item.functions.found = Number(parts[1].trim());
-        break;
-      case 'FNH':
-        item.functions.hit = Number(parts[1].trim());
-        break;
-      case 'LF':
-        item.lines.found = Number(parts[1].trim());
-        break;
-      case 'LH':
-        item.lines.hit = Number(parts[1].trim());
-        break;
-      case 'DA':
-        lines = parts[1].split(',');
-        item.lines.details.push({
-          line: Number(lines[0]),
-          hit: Number(lines[1])
-        });
-        break;
-      case 'FN':
-        fn = parts[1].split(',');
-        item.functions.details.push({
-          name: fn[1],
-          line: Number(fn[0])
-        });
-        break;
-      case 'FNDA':
-        fn = parts[1].split(',');
-        item.functions.details.some(function (i, k) {
-          if (i.name === fn[1] && i.hit === undefined) {
-            item.functions.details[k].hit = Number(fn[0]);
-            return true;
-          }
-        });
-        break;
-      case 'BRDA':
-        fn = parts[1].split(',');
-        item.branches.details.push({
-          line: Number(fn[0]),
-          block: Number(fn[1]),
-          branch: Number(fn[2]),
-          taken: ((fn[3] === '-') ? 0 : Number(fn[3]))
-        });
-        break;
-      case 'BRF':
-        item.branches.found = Number(parts[1]);
-        break;
-      case 'BRH':
-        item.branches.hit = Number(parts[1]);
-        break;
-    }
-
-    if (line.indexOf('end_of_record') > -1) {
-      data.push(item);
-      item = {
-        lines: {
-          found: 0,
-          hit: 0,
-          details: []
-        },
-        functions: {
-          hit: 0,
-          found: 0,
-          details: []
-        },
-        branches: {
-          hit: 0,
-          found: 0,
-          details: []
-        }
-      };
-    }
-  });
-
-  data.shift();
-
-  if (data.length) {
-    cb(null, data);
-  } else {
-    cb('Failed to parse string');
-  }
-};
-
-var parse = function (file, cb) {
-  exists(file, function (x) {
-    if (!x) {
-      return walkFile(file, cb);
-    }
-    fs.readFile(file, 'utf8', function (err, str) {
-      walkFile(str, cb);
-    });
-  });
-
-};
-
-var path = process.argv[2]
-parse(path, function (err, data) {
-  console.log(JSON.stringify(data, null, 2))
-});
-
-// console.log(process.argv[2])

lib/coverage_report.rb

@@ -20,25 +20,12 @@ class CoverageReport
     end
 
     def lcov(report_path, data)
-      lcov_result = execute_lcov_parse(report_path)
+      lcov = LcovParse.new(File.read("/github/workspace/#{report_path}"))
-      minumum_percent = data[:min]
+      { 'lines' => { 'covered_percent' => lcov.covered_percent, 'minumum_percent' => data[:min] } }
-      { 'lines' => { 'covered_percent' => lcov_covered_percent(lcov_result), 'minumum_percent' => minumum_percent } }
     end
 
     private
 
-    def lcov_covered_percent(lcov_result)
-      lines = lcov_result.map { |r| r['lines']['details'] }.flatten
-      total_lines = lines.count.to_f.round(2)
-      covered_lines = lines.select { |r| r['hit'] >= 1 }.count.to_f
-      ((covered_lines / total_lines) * 100).round(2)
-    end
-
-    def execute_lcov_parse(report_path)
-      bin_path = "#{File.dirname(__FILE__)}/../bin"
-      JSON.parse(`node #{bin_path}/lcov-parse.js #{report_path}`)
-    end
-
     def read_json(path)
       JSON.parse(File.read(path))
     end

lib/index.rb

@@ -7,6 +7,7 @@ require_relative './report_adapter'
 require_relative './github_check_run_service'
 require_relative './github_client'
 require_relative './coverage_report'
+require_relative './lcov_parse'
 
 def read_json(path)
   JSON.parse(File.read(path))

lib/lcov_parse.rb

@@ -0,0 +1,40 @@
+class LcovParse
+  def initialize(lcov_content)
+    @lcov = lcov_content
+  end
+
+  def to_json
+    @to_json ||= @lcov.split("end_of_record").map do |file_item|
+      file_item.split("\n").reduce({}) do |memo, item|
+        type, value = item.split(":")
+        case type
+        when "DA", "FNF", "FNH", "LF", "LH", "FN", "FNDA", "BRDA", "BRF", "BRH"
+          memo[type] = [] unless memo[type]
+          memo[type].push(value&.strip)
+        when "TN", "SF"
+          memo[type] = value
+        end
+        memo
+      end
+    end
+  end
+
+  def lines
+    @lines ||=
+      to_json.map{|it| it["DA"] }
+        .flatten.compact
+        .map{|it| it.split(",").last }
+  end
+
+  def total_lines
+    lines.count
+  end
+
+  def covered_lines
+    lines.select{|it| it == "1" }.count
+  end
+
+  def covered_percent
+    ((covered_lines / total_lines.to_f) * 100).round(2)
+  end
+end

spec/coverage_report_spec.rb

@@ -10,6 +10,6 @@ describe CoverageReport do
 
   it '.lcov' do
     result = CoverageReport.lcov('./spec/fixtures/example.lcov', min: 80)
-    expect(result['lines']['covered_percent']).to eq(85.61)
+    expect(result['lines']['covered_percent']).to eq(84.85)
   end
 end

spec/spec_helper.rb

@@ -7,3 +7,4 @@ require './lib/report_adapter'
 require './lib/github_check_run_service'
 require './lib/github_client'
 require './lib/coverage_report'
+require './lib/lcov_parse'