From 39e545fdde0cb7d2cf75b140412a87a95c952bd8 Mon Sep 17 00:00:00 2001
From: rylon <rylon@web.de>
Date: Sat, 25 Jan 2014 19:42:21 +0100
Subject: [PATCH] security - timestamp of last active updated on login

---
 ...GINS.php => SYS_SECURITY_UPDATE_LASTACTIVE.php} |  6 +++++-
 security/Security.php                              | 14 ++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)
 rename dbd/qq/{SYS_SECURITY_TRACK_LOGINS.php => SYS_SECURITY_UPDATE_LASTACTIVE.php} (67%)

diff --git a/dbd/qq/SYS_SECURITY_TRACK_LOGINS.php b/dbd/qq/SYS_SECURITY_UPDATE_LASTACTIVE.php
similarity index 67%
rename from dbd/qq/SYS_SECURITY_TRACK_LOGINS.php
rename to dbd/qq/SYS_SECURITY_UPDATE_LASTACTIVE.php
index 919b07c..9c3ca97 100644
--- a/dbd/qq/SYS_SECURITY_TRACK_LOGINS.php
+++ b/dbd/qq/SYS_SECURITY_UPDATE_LASTACTIVE.php
@@ -1,7 +1,11 @@
 <?php
 namespace SYSTEM\DBD;
 
-class SYS_SECURITY_TRACK_LOGINS extends \SYSTEM\DB\QP {
+//using QI:
+//this does not return true nessecary,
+//since if called in a very short time twice
+//the affected row count could be zero and therefore return false!
+class SYS_SECURITY_UPDATE_LASTACTIVE extends \SYSTEM\DB\QP {
     protected static function query(){
         return new \SYSTEM\DB\QQuery(get_class(),
 //pg            
diff --git a/security/Security.php b/security/Security.php
index 8e76484..24dd900 100644
--- a/security/Security.php
+++ b/security/Security.php
@@ -64,15 +64,11 @@ class Security {
                                         $row[\SYSTEM\DBD\system_user::FIELD_LOCALE],
                                         \SYSTEM\CONFIG\config::get(\SYSTEM\CONFIG\config_ids::SYS_CONFIG_PATH_BASEURL));        
         if(isset($locale)){
-            \SYSTEM\locale::set($locale);}
-        // track succesful user login
-        //self::trackLogins($row[\SYSTEM\DBD\system_user::FIELD_ID]);        
+            \SYSTEM\locale::set($locale);}                
+        \SYSTEM\DBD\SYS_SECURITY_UPDATE_LASTACTIVE::QI(array(microtime(true), $row[\SYSTEM\DBD\system_user::FIELD_ID]));
         return ($advancedResult ? $row : self::OK);
     }       
-    
-    //todo: remove
-    private static function trackLogins($userID){
-        \SYSTEM\DBD\SYS_SECURITY_TRACK_LOGINS::QQ(array(microtime(true), $userID));}
+        
 
     public static function getUser(){
         if(!self::isLoggedIn()){
@@ -122,7 +118,9 @@ class Security {
         
     public static function isLoggedIn(){
         self::startSession();
-        return (isset($_SESSION['user']) && $_SESSION['user'] instanceof User && $_SESSION['user']->base_url === \SYSTEM\CONFIG\config::get(\SYSTEM\CONFIG\config_ids::SYS_CONFIG_PATH_BASEURL));}
+        return (isset($_SESSION['user']) &&
+                $_SESSION['user'] instanceof User &&
+                $_SESSION['user']->base_url === \SYSTEM\CONFIG\config::get(\SYSTEM\CONFIG\config_ids::SYS_CONFIG_PATH_BASEURL));}
         
     private static function startSession(){
         if(!isset($_SESSION) && !headers_sent()){