Follow @Tirokk PR review suggestions

- Favor lowercase for words in a sentence after the first
- Use exclamation marks for successful actions that use a toastr
- place events at the end of the list on components
- place class above events
- it would be nice to come to a consensus based on best practices, like
  I had a doubt and places the class definition below the props, is that
what others do?
This commit is contained in:
mattwr18 2020-01-31 13:09:37 +01:00
parent 701411e270
commit c8c71a52c6
4 changed files with 8 additions and 8 deletions

View File

@ -57,11 +57,11 @@
<base-button <base-button
:title="this.$t('post.comment.reply')" :title="this.$t('post.comment.reply')"
icon="level-down" icon="level-down"
@click.prevent="reply"
v-scroll-to="'.editor'"
circle
class="reply-button" class="reply-button"
circle
size="small" size="small"
v-scroll-to="'.editor'"
@click.prevent="reply"
></base-button> ></base-button>
</ds-card> </ds-card>
</div> </div>

View File

@ -7,16 +7,16 @@
<ds-space margin-bottom="large" /> <ds-space margin-bottom="large" />
<div v-if="post.comments && post.comments.length" id="comments" class="comments"> <div v-if="post.comments && post.comments.length" id="comments" class="comments">
<comment <comment
@reply="reply"
v-for="comment in post.comments" v-for="comment in post.comments"
:key="comment.id" :key="comment.id"
:comment="comment" :comment="comment"
:post="post" :post="post"
:routeHash="routeHash" :routeHash="routeHash"
class="comment-tag"
@deleteComment="updateCommentList" @deleteComment="updateCommentList"
@updateComment="updateCommentList" @updateComment="updateCommentList"
@toggleNewCommentForm="toggleNewCommentForm" @toggleNewCommentForm="toggleNewCommentForm"
class="comment-tag" @reply="reply"
/> />
</div> </div>
</div> </div>

View File

@ -279,7 +279,7 @@
}, },
"comment": { "comment": {
"submit": "Kommentiere", "submit": "Kommentiere",
"submitted": "Kommentar Gesendet", "submitted": "Kommentar gesendet!",
"updated": "Änderungen gespeichert", "updated": "Änderungen gespeichert",
"reply": "Antworten" "reply": "Antworten"
}, },

View File

@ -444,8 +444,8 @@
}, },
"comment": { "comment": {
"submit": "Comment", "submit": "Comment",
"submitted": "Comment Submitted", "submitted": "Comment submitted!",
"updated": "Changes Saved", "updated": "Changes saved!",
"reply": "Reply" "reply": "Reply"
}, },
"edited": "edited" "edited": "edited"