6049 Commits

Author SHA1 Message Date
Robert Schäfer
cfdf9dad2c
Merge pull request #1711 from Human-Connection/407-change_your_email_address
407 change your email address
2019-10-02 17:43:19 +02:00
Robert Schäfer
c1235003c5
Merge pull request #1794 from Human-Connection/dependabot/npm_and_yarn/backend/cross-env-6.0.2
build(deps): bump cross-env from 6.0.0 to 6.0.2 in /backend
2019-10-02 15:51:36 +02:00
Robert Schäfer
551eb98150
Merge pull request #1793 from Human-Connection/dependabot/npm_and_yarn/cross-env-6.0.2
build(deps-dev): bump cross-env from 6.0.0 to 6.0.2
2019-10-02 15:51:14 +02:00
Robert Schäfer
9a08de347c
Merge pull request #1788 from Human-Connection/1663-moderators-admins-always-see-posts
Update Post query for blockedByUsers
2019-10-02 15:50:55 +02:00
roschaefer
56ce95a6fd refactor: follow review of @alina-beck + @mattwr18 2019-10-02 15:50:35 +02:00
mattwr18
263b7d0aea Fix lint 2019-10-02 10:11:39 +02:00
dependabot-preview[bot]
54061ccf88
build(deps): bump cross-env from 6.0.0 to 6.0.2 in /backend
Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 6.0.0 to 6.0.2.
- [Release notes](https://github.com/kentcdodds/cross-env/releases)
- [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kentcdodds/cross-env/compare/v6.0.0...v6.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-02 07:26:41 +00:00
dependabot-preview[bot]
c5fd384517
build(deps-dev): bump cross-env from 6.0.0 to 6.0.2
Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 6.0.0 to 6.0.2.
- [Release notes](https://github.com/kentcdodds/cross-env/releases)
- [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kentcdodds/cross-env/compare/v6.0.0...v6.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-02 07:26:28 +00:00
mattwr18
ec4d361df6
Merge pull request #1792 from Human-Connection/dependabot/npm_and_yarn/backend/metascraper-description-5.7.6
build(deps): bump metascraper-description from 5.7.5 to 5.7.6 in /backend
2019-10-02 09:25:15 +02:00
mattwr18
3297461ab8
Merge pull request #1791 from Human-Connection/dependabot/npm_and_yarn/webapp/cross-env-6.0.2
build(deps): bump cross-env from 6.0.0 to 6.0.2 in /webapp
2019-10-02 09:24:52 +02:00
mattwr18
9cffe76ea4
Merge pull request #1790 from Human-Connection/dependabot/npm_and_yarn/webapp/nuxtjs/apollo-4.0.0-rc14
build(deps): bump @nuxtjs/apollo from 4.0.0-rc13.1 to 4.0.0-rc14 in /webapp
2019-10-02 09:24:28 +02:00
mattwr18
f0d096fcab Prefer guard clause to avoid database call
- follow @roschaefer's PR review
2019-10-02 09:20:13 +02:00
dependabot-preview[bot]
8e8fff21b7
build(deps): bump metascraper-description in /backend
Bumps [metascraper-description](https://github.com/microlinkhq/metascraper) from 5.7.5 to 5.7.6.
- [Release notes](https://github.com/microlinkhq/metascraper/releases)
- [Changelog](https://github.com/microlinkhq/metascraper/blob/master/CHANGELOG.md)
- [Commits](https://github.com/microlinkhq/metascraper/compare/v5.7.5...v5.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-02 05:40:33 +00:00
dependabot-preview[bot]
02537b37f4
build(deps): bump cross-env from 6.0.0 to 6.0.2 in /webapp
Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 6.0.0 to 6.0.2.
- [Release notes](https://github.com/kentcdodds/cross-env/releases)
- [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kentcdodds/cross-env/compare/v6.0.0...v6.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-02 05:37:48 +00:00
dependabot-preview[bot]
4648080a74
build(deps): bump @nuxtjs/apollo in /webapp
Bumps [@nuxtjs/apollo](https://github.com/nuxt-community/apollo-module) from 4.0.0-rc13.1 to 4.0.0-rc14.
- [Release notes](https://github.com/nuxt-community/apollo-module/releases)
- [Commits](https://github.com/nuxt-community/apollo-module/compare/v4.0.0-rc.13.1...v4.0.0-rc.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-02 05:36:47 +00:00
roschaefer
1e31a0c620 fix: remove previous email address on change
This will allow you to change back to your previous email address: The
backend won't complain because of a user who owns that email address
already.
2019-10-02 01:55:14 +02:00
roschaefer
e6f8bbac9b fix: remove copy+paste oversights
In the registration resolvers, it makes sense to immediately resolve if
an email address has been found (because you can re-send the
registration email).

In this case, we use the helper method only to trigger the `UserInputError`.
2019-10-02 01:54:28 +02:00
roschaefer
6ffafff288 fix: ensure no other user owns a new email address
`BELONGS_TO` means a user owns an email address. `PRIMARY_EMAIL` means a
user authenticates with that email.

So right now, you get a proper error message if you try to change your
email back to your old email address (because you own it already).

I will make sure to delete the old email so this will be no problem
anymore. But maybe in the future we might have multiple email addresses
per user and then it makes a big difference to use `PRIMARY_EMAIL` or
`BELONGS_TO`.
2019-10-02 01:31:23 +02:00
roschaefer
6a7970200f refactor: EmailAddr.Request -> UnverifiedEmailAddr. 2019-10-02 01:21:56 +02:00
roschaefer
7bec48904e refactor: improve language of validation message 2019-10-02 01:14:57 +02:00
roschaefer
4ac80b0d58 refactor: align submit buttons consistently
@alina-beck said we have most buttons left-aligned, so I went with that:
https://github.com/Human-Connection/Human-Connection/pull/1711#discussion_r329505767

Also this uses icon `envelope` for emails. This makes sense, because we
could use icon `at` for slugs.
2019-10-02 01:10:28 +02:00
roschaefer
15e3a5690c refactor: change all hyphenated spellings to email 2019-10-02 00:58:23 +02:00
roschaefer
01e583b45e Translate backend error and avoid $toast 2019-10-02 00:54:01 +02:00
roschaefer
5848e6af18 Fix a TODO by @alina-beck 2019-10-02 00:54:01 +02:00
roschaefer
76841d27f1 Styling 2019-10-02 00:54:01 +02:00
roschaefer
573edce788 Show at least the error message in SSR 2019-10-02 00:54:01 +02:00
roschaefer
3e3452c7bc Better help messages, styling 2019-10-02 00:54:01 +02:00
roschaefer
69cd41d3eb Test email verification page 2019-10-02 00:54:01 +02:00
roschaefer
6a212fb668 Test verify-nonce page 2019-10-02 00:54:01 +02:00
roschaefer
f61441d3e6 Test my-email-address settings page 2019-10-02 00:54:01 +02:00
roschaefer
e116d52992 Use EmailAddressRequest and validate email 2019-10-02 00:54:01 +02:00
Alina Beck
707cf741de write text for verification email 2019-10-02 00:54:01 +02:00
roschaefer
2b490e00d7 wrap email templates in standard layout to minimize duplicate code 2019-10-02 00:54:01 +02:00
roschaefer
89cc6da5f1 Don't redirect if email change was not successful 2019-10-02 00:54:01 +02:00
roschaefer
9808e1c4f8 Validate different email address 2019-10-02 00:54:01 +02:00
roschaefer
69542617ac Split routes in two
So, to get a direct link it's better to have one route that calls a
mutation as soon as it is visited.
2019-10-02 00:54:01 +02:00
roschaefer
0592f685f6 Basic email change works 2019-10-02 00:54:01 +02:00
roschaefer
80ce079920 Implement first page to change email address 2019-10-02 00:54:01 +02:00
roschaefer
e51124f316 Resolvers for EmailAddress implemented 2019-10-02 00:54:01 +02:00
roschaefer
8c13234af9 Handle edge case
It might be that people try to register email addresses that they don't own. Then if the actual owner tries to add this email address, she should not get a unique constraint violation. Instead the email will be re-used.

Is this a security issue? Because we re-use the nonce? 🤔
2019-10-02 00:54:01 +02:00
roschaefer
73d5abd724 Implement AddEmail resolver 2019-10-02 00:54:01 +02:00
roschaefer
3b6cd55c0f Implement unauthenticated part 2019-10-02 00:54:01 +02:00
roschaefer
8a05de5b2d Sketch backend test to change Email Address 2019-10-02 00:54:01 +02:00
Robert Schäfer
5d5540d8c8
Merge pull request #1779 from Human-Connection/dependabot/npm_and_yarn/backend/metascraper-audio-5.7.6
Bump metascraper-audio from 5.7.5 to 5.7.6 in /backend
2019-10-01 23:46:07 +02:00
Robert Schäfer
b31126c391
Merge pull request #1701 from Human-Connection/1273-fix-post-page-nav
fix the bug with scrolling post comments into view
2019-10-01 23:17:53 +02:00
dependabot-preview[bot]
c3e7b3938a
Bump metascraper-audio from 5.7.5 to 5.7.6 in /backend
Bumps [metascraper-audio](https://github.com/microlinkhq/metascraper) from 5.7.5 to 5.7.6.
- [Release notes](https://github.com/microlinkhq/metascraper/releases)
- [Changelog](https://github.com/microlinkhq/metascraper/blob/master/CHANGELOG.md)
- [Commits](https://github.com/microlinkhq/metascraper/compare/v5.7.5...v5.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-01 21:10:18 +00:00
Robert Schäfer
7ecb9d8bed
Merge pull request #1778 from Human-Connection/dependabot/npm_and_yarn/backend/metascraper-publisher-5.7.6
Bump metascraper-publisher from 5.7.4 to 5.7.6 in /backend
2019-10-01 23:07:09 +02:00
mattwr18
d9bfad68a9 Update scenario description
- to be more similar to other descriptions of the file
2019-10-01 21:59:25 +02:00
mattwr18
624922b0e6 Check that reported post can be visited
- want to verify that it is not a post not found 402
2019-10-01 21:29:48 +02:00
mattwr18
478f6fef1c Fix query builder/test 2019-10-01 20:57:45 +02:00