change review from Ulf, rename File Memo.vue to MemoRow.vue, add required on props

This commit is contained in:
ogerly 2022-03-11 10:34:39 +01:00
parent e34654edda
commit ebcc73c153
11 changed files with 33 additions and 18 deletions

View File

@ -108,6 +108,10 @@ export default {
}
</script>
<style>
collaps-icon {
width: 95%;
position: absolute;
}
.el-table .cell {
padding-left: 0px;
padding-right: 0px;

View File

@ -89,11 +89,6 @@ export default {
}
</script>
<style>
collaps-icon {
width: 95%;
position: absolute;
}
.el-table .cell {
padding-left: 0px;
padding-right: 0px;

View File

@ -10,7 +10,7 @@
</b-col>
<b-col cols="7">
<div class="gdd-transaction-list-item-name">
{{ linkedUser ? linkedUser.firstName + ' ' + linkedUser.lastName : text }}
{{ itemText }}
</div>
</b-col>
</b-row>
@ -18,16 +18,26 @@
</template>
<script>
export default {
name: 'AmountAndName',
name: 'Amount-And-Name',
props: {
amount: {
type: String,
required: true,
},
linkedUser: {
type: Object,
required: false,
},
text: {
type: String,
required: false,
},
},
computed: {
itemText() {
return this.linkedUser
? this.linkedUser.firstName + ' ' + this.linkedUser.lastName
: this.text
},
},
}

View File

@ -12,6 +12,7 @@ export default {
props: {
visible: {
type: Boolean,
required: true,
},
},
}

View File

@ -19,6 +19,7 @@ export default {
props: {
balanceDate: {
type: String,
required: true,
},
},
}

View File

@ -24,6 +24,7 @@ export default {
props: {
decay: {
type: Object,
required: false,
},
},
}

View File

@ -1,5 +1,5 @@
<template>
<div class="memo">
<div class="memo-row">
<b-row>
<b-col cols="5">
<div class="text-right">{{ $t('form.memo') }}</div>
@ -12,10 +12,11 @@
</template>
<script>
export default {
name: 'Memo',
name: 'Memo-Row',
props: {
memo: {
type: String,
required: false,
},
},
}

View File

@ -11,9 +11,11 @@ export default {
props: {
icon: {
type: String,
required: true,
},
color: {
type: String,
required: true,
},
},
}

View File

@ -16,7 +16,7 @@
<amount-and-name :amount="amount" :linkedUser="linkedUser" />
<!-- Nachricht Memo -->
<memo :memo="memo" />
<memo-row :memo="memo" />
<!-- Datum -->
<date-row :balanceDate="balanceDate" />
@ -42,7 +42,7 @@
import CollapseIcon from '../TransactionRows/CollapseIcon'
import TypeIcon from '../TransactionRows/TypeIcon'
import AmountAndName from '../TransactionRows/AmountAndName'
import Memo from '../TransactionRows/Memo'
import MemoRow from '../TransactionRows/MemoRow'
import DateRow from '../TransactionRows/DateRow'
import DecayRow from '../TransactionRows/DecayRow'
import DecayInformation from '../DecayInformations/DecayInformation'
@ -53,7 +53,7 @@ export default {
CollapseIcon,
TypeIcon,
AmountAndName,
Memo,
MemoRow,
DateRow,
DecayRow,
DecayInformation,

View File

@ -16,7 +16,7 @@
<amount-and-name :amount="amount" :linkedUser="linkedUser" />
<!-- Nachricht Memo -->
<memo :memo="memo" />
<memo-row :memo="memo" />
<!-- Datum -->
<date-row :balanceDate="balanceDate" />
@ -42,7 +42,7 @@
import CollapseIcon from '../TransactionRows/CollapseIcon'
import TypeIcon from '../TransactionRows/TypeIcon'
import AmountAndName from '../TransactionRows/AmountAndName'
import Memo from '../TransactionRows/Memo'
import MemoRow from '../TransactionRows/MemoRow'
import DateRow from '../TransactionRows/DateRow'
import DecayRow from '../TransactionRows/DecayRow'
import DecayInformation from '../DecayInformations/DecayInformation'
@ -53,7 +53,7 @@ export default {
CollapseIcon,
TypeIcon,
AmountAndName,
Memo,
MemoRow,
DateRow,
DecayRow,
DecayInformation,

View File

@ -16,7 +16,7 @@
<amount-and-name :amount="amount" :linkedUser="linkedUser" />
<!-- Memo -->
<memo :memo="memo" />
<memo-row :memo="memo" />
<!-- Datum -->
<date-row :balanceDate="balanceDate" />
@ -42,7 +42,7 @@
import CollapseIcon from '../TransactionRows/CollapseIcon'
import TypeIcon from '../TransactionRows/TypeIcon'
import AmountAndName from '../TransactionRows/AmountAndName'
import Memo from '../TransactionRows/Memo'
import MemoRow from '../TransactionRows/MemoRow'
import DateRow from '../TransactionRows/DateRow'
import DecayRow from '../TransactionRows/DecayRow'
import DecayInformation from '../DecayInformations/DecayInformation'
@ -53,7 +53,7 @@ export default {
CollapseIcon,
TypeIcon,
AmountAndName,
Memo,
MemoRow,
DateRow,
DecayRow,
DecayInformation,